1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: cleanup test-c-ares.js

Browse Source 
Replace equal with strictEqual, use const instead of var
Replace throw error with assert.ifError

PR-URL: https://github.com/nodejs/node/pull/8577
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This commit is contained in:
Yevgen Safronov 2016-09-17 10:22:42 +02:00 committed by Ilkka Myller
parent 366495d4e2
commit 9fb59dfa39
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/parallel/test-c-ares.js
View File

@ -1,26 +1,26 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var dns = require('dns'); const dns = require('dns');
// Try resolution without callback // Try resolution without callback
dns.lookup(null, function(error, result, addressType) { dns.lookup(null, common.mustCall(function(error, result, addressType) {
assert.equal(null, result); assert.strictEqual(null, result);
assert.equal(4, addressType); assert.strictEqual(4, addressType);
}); }));
dns.lookup('127.0.0.1', function(error, result, addressType) { dns.lookup('127.0.0.1', common.mustCall(function(error, result, addressType) {
assert.equal('127.0.0.1', result); assert.strictEqual('127.0.0.1', result);
assert.equal(4, addressType); assert.strictEqual(4, addressType);
}); }));
dns.lookup('::1', function(error, result, addressType) { dns.lookup('::1', common.mustCall(function(error, result, addressType) {
assert.equal('::1', result); assert.strictEqual('::1', result);
assert.equal(6, addressType); assert.strictEqual(6, addressType);
}); }));
// Try calling resolve with an unsupported type. // Try calling resolve with an unsupported type.
assert.throws(function() { assert.throws(function() {
@ -36,8 +36,8 @@ assert.throws(function() {
// C:\Windows\System32\drivers\etc\hosts // C:\Windows\System32\drivers\etc\hosts
// so we disable this test on Windows. // so we disable this test on Windows.
if (!common.isWindows) { if (!common.isWindows) {
dns.reverse('127.0.0.1', function(error, domains) { dns.reverse('127.0.0.1', common.mustCall(function(error, domains) {
if (error) throw error; assert.ifError(error);
assert.ok(Array.isArray(domains)); assert.ok(Array.isArray(domains));
}); }));
} }