1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: move timer-dependent test to sequential

Browse Source 
Timer-dependent tests fail frequently on certain platforms in CI when
run in parallel with other tests, likely due to competition for
resources. Move test-repl-timeout-throw to sequential to avoid this
problem. Also did some minor refactoring (var->const and more use of
assert.strictEqual of looser assertions).

PR-URL: https://github.com/nodejs/node/pull/9431
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu>
This commit is contained in:
Rich Trott 2016-11-02 20:06:50 -07:00
parent a02b13fe9b
commit 9fa94237c8
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-repl-timeout-throw.js → test/sequential/test-repl-timeout-throw.js
View File

@ -1,10 +1,10 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
var child = spawn(process.execPath, [ '-i' ], { const child = spawn(process.execPath, [ '-i' ], {
stdio: [null, null, 2] stdio: [null, null, 2]
}); });
@ -52,8 +52,8 @@ child.stdout.once('data', function() {
}); });
child.on('close', function(c) { child.on('close', function(c) {
assert(!c); assert.strictEqual(c, 0);
// make sure we got 3 throws, in the end. // make sure we got 3 throws, in the end.
var lastLine = stdout.trim().split(/\r?\n/).pop(); var lastLine = stdout.trim().split(/\r?\n/).pop();
assert.equal(lastLine, '> 3'); assert.strictEqual(lastLine, '> 3');
}); });