1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

assert: remove unnecessary use of __proto__

Browse Source 
AssertionError already inherits from Error above using util.inherits(),
so this extra line was redundant.

test/simple/test-assert.js already tests for `instanceof`, and still passes.
This commit is contained in:
Nathan Rajlich 2012-07-25 10:34:13 -07:00
parent b207e24bcd
commit 9eddaebb79
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/assert.js
View File

@ -49,6 +49,8 @@ assert.AssertionError = function AssertionError(options) {
Error.captureStackTrace(this, stackStartFunction); Error.captureStackTrace(this, stackStartFunction);
} }
}; };
// assert.AssertionError instanceof Error
util.inherits(assert.AssertionError, Error); util.inherits(assert.AssertionError, Error);
function replacer(key, value) { function replacer(key, value) {
@ -85,10 +87,6 @@ assert.AssertionError.prototype.toString = function() {
} }
}; };
// assert.AssertionError instanceof Error
assert.AssertionError.__proto__ = Error.prototype;
// At present only the three keys mentioned above are used and // At present only the three keys mentioned above are used and
// understood by the spec. Implementations or sub modules can pass // understood by the spec. Implementations or sub modules can pass
// other keys to the AssertionError's constructor - they will be // other keys to the AssertionError's constructor - they will be