1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-crypto-random

Browse Source 
* specify constructor for assert.throws()
* load additional modules only if crypto check passes
* normalize some potentially confusing indentation
* provided actual first and expected second in assertions

PR-URL: https://github.com/nodejs/node/pull/10232
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Rich Trott 2016-12-11 20:34:52 -08:00 committed by Italo A. Casas
parent 6f02957846
commit 9e92817119
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/parallel/test-crypto-random.js
View File

@ -1,11 +1,11 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert');
if (!common.hasCrypto) { if (!common.hasCrypto) {
common.skip('missing crypto'); common.skip('missing crypto');
return; return;
} }
const assert = require('assert');
const crypto = require('crypto'); const crypto = require('crypto');
crypto.DEFAULT_ENCODING = 'buffer'; crypto.DEFAULT_ENCODING = 'buffer';
@ -13,25 +13,16 @@ crypto.DEFAULT_ENCODING = 'buffer';
// bump, we register a lot of exit listeners // bump, we register a lot of exit listeners
process.setMaxListeners(256); process.setMaxListeners(256);
[crypto.randomBytes, [crypto.randomBytes, crypto.pseudoRandomBytes].forEach(function(f) {
crypto.pseudoRandomBytes [-1, undefined, null, false, true, {}, []].forEach(function(value) {
].forEach(function(f) { assert.throws(function() { f(value); }, TypeError);
[-1, assert.throws(function() { f(value, function() {}); }, TypeError);
undefined,
null,
false,
true,
{},
[]
].forEach(function(value) {
assert.throws(function() { f(value); });
assert.throws(function() { f(value, function() {}); });
}); });
[0, 1, 2, 4, 16, 256, 1024].forEach(function(len) { [0, 1, 2, 4, 16, 256, 1024].forEach(function(len) {
f(len, common.mustCall(function(ex, buf) { f(len, common.mustCall(function(ex, buf) {
assert.strictEqual(null, ex); assert.strictEqual(ex, null);
assert.strictEqual(len, buf.length); assert.strictEqual(buf.length, len);
assert.ok(Buffer.isBuffer(buf)); assert.ok(Buffer.isBuffer(buf));
})); }));
}); });