1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: increase coverage of process.emitWarning

Browse Source 
Previously our tests did not check these codepaths as seen at
coverage.nodejs.org

PR-URL: https://github.com/nodejs/node/pull/9556
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Jeremiah Senkpiel 2016-11-11 15:57:18 -05:00
parent fc44bd4d0b
commit 9e698bd6db
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-process-emitwarning.js
View File

@ -10,10 +10,12 @@ process.on('warning', common.mustCall((warning) => {
assert(warning); assert(warning);
assert(/^(Warning|CustomWarning)/.test(warning.name)); assert(/^(Warning|CustomWarning)/.test(warning.name));
assert(warning.message, 'A Warning'); assert(warning.message, 'A Warning');
}, 3)); }, 7));
process.emitWarning('A Warning'); process.emitWarning('A Warning');
process.emitWarning('A Warning', 'CustomWarning'); process.emitWarning('A Warning', 'CustomWarning');
process.emitWarning('A Warning', CustomWarning);
process.emitWarning('A Warning', 'CustomWarning', CustomWarning);
function CustomWarning() { function CustomWarning() {
Error.call(this); Error.call(this);
@ -24,6 +26,16 @@ function CustomWarning() {
util.inherits(CustomWarning, Error); util.inherits(CustomWarning, Error);
process.emitWarning(new CustomWarning()); process.emitWarning(new CustomWarning());
const warningNoToString = new CustomWarning();
warningNoToString.toString = null;
process.emitWarning(warningNoToString);
const warningThrowToString = new CustomWarning();
warningThrowToString.toString = function() {
throw new Error('invalid toString');
};
process.emitWarning(warningThrowToString);
// TypeError is thrown on invalid output // TypeError is thrown on invalid output
assert.throws(() => process.emitWarning(1), TypeError); assert.throws(() => process.emitWarning(1), TypeError);
assert.throws(() => process.emitWarning({}), TypeError); assert.throws(() => process.emitWarning({}), TypeError);