1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use default assertion message

Browse Source 
In test-child-process-spawnsync, the assert.strictEqual() custom
message was hiding information about why the test has failed. It
just showed what value is expected and in case of failure we want to
know which value has caused test to fail.

PR-URL: https://github.com/nodejs/node/pull/16819
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
jonask 2017-11-06 17:28:03 +02:00 committed by Rich Trott
parent 37c118810c
commit 9e4fa6c890
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-child-process-spawnsync.js
View File

@ -28,7 +28,7 @@ const spawnSync = require('child_process').spawnSync;
// Echo does different things on Windows and Unix, but in both cases, it does
// more-or-less nothing if there are no parameters
const ret = spawnSync('sleep', ['0']);
assert.strictEqual(ret.status, 0, 'exit status should be zero');
assert.strictEqual(ret.status, 0);
// Error test when command does not exist
const ret_err = spawnSync('command_does_not_exist', ['bar']).error;