1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check for the correct strict equal arguments order

Browse Source 
This activates a eslint rule to verify that the `assert.strictEqual()`
arguments are in the correct order.

PR-URL: https://github.com/nodejs/node/pull/24752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Ruben Bridgewater 2018-11-18 04:33:46 +01:00 committed by Rich Trott
parent a89b873e63
commit 9e12409ec3
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/.eslintrc.yaml
View File

@ -48,9 +48,8 @@ rules:
message: "The first argument should be the `actual`, not the `expected` value." message: "The first argument should be the `actual`, not the `expected` value."
- selector: "CallExpression[callee.object.name='assert'][callee.property.name='deepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression'])" - selector: "CallExpression[callee.object.name='assert'][callee.property.name='deepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression'])"
message: "The first argument should be the `actual`, not the `expected` value." message: "The first argument should be the `actual`, not the `expected` value."
# TODO: Activate the `strictEqual` rule as soon as it produces less churn. - selector: "CallExpression[callee.object.name='assert'][callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression'])"
# - selector: "CallExpression[callee.object.name='assert'][callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression'])" message: "The first argument should be the `actual`, not the `expected` value."
# message: "The first argument should be the `actual`, not the `expected` value."
# Global scoped methods and vars # Global scoped methods and vars
globals: globals:
WebAssembly: false WebAssembly: false

6
test/parallel/test-http-blank-header.js
View File

@ -28,11 +28,11 @@ const net = require('net');
const server = http.createServer(common.mustCall((req, res) => { const server = http.createServer(common.mustCall((req, res) => {
assert.strictEqual(req.method, 'GET'); assert.strictEqual(req.method, 'GET');
assert.strictEqual(req.url, '/blah'); assert.strictEqual(req.url, '/blah');
assert.deepStrictEqual({ assert.deepStrictEqual(req.headers, {
host: 'example.org:443', host: 'example.org:443',
origin: 'http://example.org', origin: 'http://example.org',
cookie: '' cookie: ''
}, req.headers); });
})); }));
@ -52,7 +52,7 @@ server.listen(0, common.mustCall(() => {
received += data.toString(); received += data.toString();
})); }));
c.on('end', common.mustCall(() => { c.on('end', common.mustCall(() => {
assert.strictEqual('HTTP/1.1 400 Bad Request\r\n\r\n', received); assert.strictEqual(received, 'HTTP/1.1 400 Bad Request\r\n\r\n');
c.end(); c.end();
})); }));
c.on('close', common.mustCall(() => server.close())); c.on('close', common.mustCall(() => server.close()));

2
test/parallel/test-process-env.js
View File

@ -68,7 +68,7 @@ if (process.argv[2] === 'you-are-the-child') {
// delete should return true except for non-configurable properties // delete should return true except for non-configurable properties
// https://github.com/nodejs/node/issues/7960 // https://github.com/nodejs/node/issues/7960
delete process.env.NON_EXISTING_VARIABLE; delete process.env.NON_EXISTING_VARIABLE;
assert.strictEqual(true, delete process.env.NON_EXISTING_VARIABLE); assert(delete process.env.NON_EXISTING_VARIABLE);
/* For the moment we are not going to support setting the timezone via the /* For the moment we are not going to support setting the timezone via the
* environment variables. The problem is that various V8 platform backends * environment variables. The problem is that various V8 platform backends