1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed async fs writes with length 0, it should fire the callback

Browse Source
This commit is contained in:
Marco Rogers 2010-08-24 23:46:37 -04:00 committed by Ryan Dahl
parent d5214b3627
commit 9c7c6e93e1
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/fs.js
View File

@ -211,7 +211,15 @@ fs.write = function (fd, buffer, offset, length, position, callback) {
offset = 0; offset = 0;
length = buffer.length; length = buffer.length;
} }
if(!length) return;
if (!length) {
if (typeof callback == 'function') {
process.nextTick(function() {
callback(undefined, 0);
});
}
return;
}
binding.write(fd, buffer, offset, length, position, callback || noop); binding.write(fd, buffer, offset, length, position, callback || noop);
}; };

2
test/simple/test-fs-write.js
View File

@ -11,7 +11,7 @@ fs.open(fn, 'w', 0644, function (err, fd) {
if (err) throw err; if (err) throw err;
console.log('open done'); console.log('open done');
fs.write(fd, '', 0, 'utf8', function(err, written) { fs.write(fd, '', 0, 'utf8', function(err, written) {
assert.fail('zero length write should not go through to callback'); assert.equal(0, written);
}); });
fs.write(fd, expected, 0, "utf8", function (err, written) { fs.write(fd, expected, 0, "utf8", function (err, written) {
console.log('write done'); console.log('write done');