1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc,meta: update PR approving info

Browse Source 
Refs: https://github.com/nodejs/node/pull/22255

PR-URL: https://github.com/nodejs/node/pull/24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
Vse Mozhet Byt 2018-11-22 00:38:05 +02:00 committed by Rich Trott
parent d1a55d329a
commit 9c7b87b9a1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/guides/contributing/pull-requests.md
View File

@ -347,7 +347,8 @@ unhelpful is likely safe to ignore.
### Step 10: Landing
In order to land, a Pull Request needs to be reviewed and [approved][] by
at least one Node.js Collaborator and pass a
at least two Node.js Collaborators (one Collaborator approval is enough if the
pull request has been open for more than 7 days) and pass a
[CI (Continuous Integration) test run][]. After that, as long as there are no
objections from other contributors, the Pull Request can be merged. If you find
your Pull Request waiting longer than you expect, see the