1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: make test-worker-esm-missing-main more robust

Browse Source 
test-worker-esm-missing-main failed in CI recently in a way that
suggests that maybe the `does-not-exist.js` file did in fact exist.
Maybe that isn't what happened at all, but let's rule it out by changing
the use of `does-not-exist.js` from a file expected to be missing from
the current working directory to a file in the temp directory, which the
test will remove and recreate at the outset.

PR-URL: https://github.com/nodejs/node/pull/27340
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This commit is contained in:
Rich Trott 2019-04-21 22:25:37 -07:00
parent 1a54d0fa59
commit 9b982feedf
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-worker-esm-missing-main.js
View File

@ -1,11 +1,14 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const path = require('path');
const { Worker } = require('worker_threads'); const { Worker } = require('worker_threads');
const worker = new Worker('./does-not-exist.js', { const tmpdir = require('../common/tmpdir');
execArgv: ['--experimental-modules'], tmpdir.refresh();
}); const missing = path.join(tmpdir.path, 'does-not-exist.js');
const worker = new Worker(missing, { execArgv: ['--experimental-modules'] });
worker.on('error', common.mustCall((err) => { worker.on('error', common.mustCall((err) => {
// eslint-disable-next-line node-core/no-unescaped-regexp-dot // eslint-disable-next-line node-core/no-unescaped-regexp-dot