1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dtrace: check if _handle property is set

Browse Source 
Check that _handle is an object before trying to read its `fd`
property, avoids bogus values.
This commit is contained in:
Ben Noordhuis 2013-03-30 01:49:19 +01:00
parent aa5da48594
commit 9b8dd39553
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node_dtrace.cc
View File

@ -91,8 +91,12 @@ using namespace v8;
} \ } \
node_dtrace_connection_t conn; \ node_dtrace_connection_t conn; \
Local<Object> _##conn = Local<Object>::Cast(arg); \ Local<Object> _##conn = Local<Object>::Cast(arg); \
Local<Object> _handle = (_##conn)->Get(String::New("_handle"))->ToObject(); \ Local<Value> _handle = (_##conn)->Get(String::New("_handle")); \
SLURP_INT(_handle, fd, &conn.fd); \ if (_handle->IsObject()) { \
SLURP_INT(_handle.As<Object>(), fd, &conn.fd); \
} else { \
conn.fd = -1; \
} \
SLURP_STRING(_##conn, remoteAddress, &conn.remote); \ SLURP_STRING(_##conn, remoteAddress, &conn.remote); \
SLURP_INT(_##conn, remotePort, &conn.port); \ SLURP_INT(_##conn, remotePort, &conn.port); \
SLURP_INT(_##conn, bufferSize, &conn.buffered); SLURP_INT(_##conn, bufferSize, &conn.buffered);