1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove unnecessary assertions

Browse Source 
It’s not necessary to assert that the internal `hasRef()`
method exists, since it is always called directly afterwards
in these tests. Furthermore, the test is overly specific,
in that it expects them on a specific position in the prototype
chain.

PR-URL: https://github.com/nodejs/node/pull/23040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Anna Henningsen 2018-09-23 19:28:27 +02:00
parent 0434d270c1
commit 9b292272ff
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-handle-wrap-isrefed.js
View File

@ -10,8 +10,6 @@ const { internalBinding } = require('internal/test/binding');
const spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
const cmd = common.isWindows ? 'rundll32' : 'ls'; const cmd = common.isWindows ? 'rundll32' : 'ls';
const cp = spawn(cmd); const cp = spawn(cmd);
strictEqual(Object.getPrototypeOf(cp._handle).hasOwnProperty('hasRef'),
true, 'process_wrap: hasRef() missing');
strictEqual(cp._handle.hasRef(), strictEqual(cp._handle.hasRef(),
true, 'process_wrap: not initially refed'); true, 'process_wrap: not initially refed');
cp.unref(); cp.unref();
@ -34,8 +32,6 @@ const { kStateSymbol } = require('internal/dgram');
const sock4 = dgram.createSocket('udp4'); const sock4 = dgram.createSocket('udp4');
const handle = sock4[kStateSymbol].handle; const handle = sock4[kStateSymbol].handle;
strictEqual(Object.getPrototypeOf(handle).hasOwnProperty('hasRef'),
true, 'udp_wrap: ipv4: hasRef() missing');
strictEqual(handle.hasRef(), strictEqual(handle.hasRef(),
true, 'udp_wrap: ipv4: not initially refed'); true, 'udp_wrap: ipv4: not initially refed');
sock4.unref(); sock4.unref();
@ -55,8 +51,6 @@ const { kStateSymbol } = require('internal/dgram');
const sock6 = dgram.createSocket('udp6'); const sock6 = dgram.createSocket('udp6');
const handle = sock6[kStateSymbol].handle; const handle = sock6[kStateSymbol].handle;
strictEqual(Object.getPrototypeOf(handle).hasOwnProperty('hasRef'),
true, 'udp_wrap: ipv6: hasRef() missing');
strictEqual(handle.hasRef(), strictEqual(handle.hasRef(),
true, 'udp_wrap: ipv6: not initially refed'); true, 'udp_wrap: ipv6: not initially refed');
sock6.unref(); sock6.unref();
@ -75,8 +69,6 @@ const { kStateSymbol } = require('internal/dgram');
{ {
const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap'); const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
const handle = new Pipe(PipeConstants.SOCKET); const handle = new Pipe(PipeConstants.SOCKET);
strictEqual(Object.getPrototypeOf(handle).hasOwnProperty('hasRef'),
true, 'pipe_wrap: hasRef() missing');
strictEqual(handle.hasRef(), strictEqual(handle.hasRef(),
true, 'pipe_wrap: not initially refed'); true, 'pipe_wrap: not initially refed');
handle.unref(); handle.unref();
@ -95,8 +87,6 @@ const { kStateSymbol } = require('internal/dgram');
{ {
const net = require('net'); const net = require('net');
const server = net.createServer(() => {}).listen(0); const server = net.createServer(() => {}).listen(0);
strictEqual(Object.getPrototypeOf(server._handle).hasOwnProperty('hasRef'),
true, 'tcp_wrap: hasRef() missing');
strictEqual(server._handle.hasRef(), strictEqual(server._handle.hasRef(),
true, 'tcp_wrap: not initially refed'); true, 'tcp_wrap: not initially refed');
strictEqual(server._unref, strictEqual(server._unref,

2
test/pseudo-tty/test-handle-wrap-isrefed-tty.js
View File

@ -10,8 +10,6 @@ const tty = new ReadStream(0);
const { internalBinding } = require('internal/test/binding'); const { internalBinding } = require('internal/test/binding');
const isTTY = internalBinding('tty_wrap').isTTY; const isTTY = internalBinding('tty_wrap').isTTY;
strictEqual(isTTY(0), true, 'tty_wrap: stdin is not a TTY'); strictEqual(isTTY(0), true, 'tty_wrap: stdin is not a TTY');
strictEqual(Object.getPrototypeOf(tty._handle).hasOwnProperty('hasRef'),
true, 'tty_wrap: hasRef() missing');
strictEqual(tty._handle.hasRef(), strictEqual(tty._handle.hasRef(),
true, 'tty_wrap: not initially refed'); true, 'tty_wrap: not initially refed');
tty.unref(); tty.unref();