1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stream: refactor getHighWaterMark in state.js

Browse Source 
This commit aims to reduce some code duplication in state.js

PR-URL: https://github.com/nodejs/node/pull/20415
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Daniel Bevenius 2018-04-30 07:14:00 +02:00 committed by Ruben Bridgewater
parent 7d81f5d143
commit 9b24be1340
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/internal/streams/state.js
View File

@ -2,19 +2,19 @@
const { ERR_INVALID_OPT_VALUE } = require('internal/errors').codes; const { ERR_INVALID_OPT_VALUE } = require('internal/errors').codes;
function highWaterMarkFrom(options, isDuplex, duplexKey) {
return options.highWaterMark != null ? options.highWaterMark :
isDuplex ? options[duplexKey] : null;
}
function getHighWaterMark(state, options, duplexKey, isDuplex) { function getHighWaterMark(state, options, duplexKey, isDuplex) {
let hwm = options.highWaterMark; const hwm = highWaterMarkFrom(options, isDuplex, duplexKey);
if (hwm != null) { if (hwm != null) {
if (typeof hwm !== 'number' || !(hwm >= 0)) if (!Number.isInteger(hwm) || hwm < 0) {
throw new ERR_INVALID_OPT_VALUE('highWaterMark', hwm); const name = isDuplex ? duplexKey : 'highWaterMark';
return Math.floor(hwm); throw new ERR_INVALID_OPT_VALUE(name, hwm);
} else if (isDuplex) {
hwm = options[duplexKey];
if (hwm != null) {
if (typeof hwm !== 'number' || !(hwm >= 0))
throw new ERR_INVALID_OPT_VALUE(duplexKey, hwm);
return Math.floor(hwm);
} }
return Math.floor(hwm);
} }
// Default value // Default value