1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "src: fix stuck debugger process"

Browse Source 
This reverts commit ff877e93e16971ab8514772bd8d112e240b74803.

Reverted for breaking `node --debug-brk -e 0`.  It should immediately
quit but instead it hangs now.

PR-URL: https://github.com/nodejs/node/pull/3585
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ben Noordhuis 2015-10-29 13:33:03 +01:00
parent 57bce60da3
commit 9b024422cd
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node.cc
View File

@ -3747,6 +3747,7 @@ void Init(int* argc,
uv_async_init(uv_default_loop(), uv_async_init(uv_default_loop(),
&dispatch_debug_messages_async, &dispatch_debug_messages_async,
DispatchDebugMessagesAsyncCallback); DispatchDebugMessagesAsyncCallback);
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
#if defined(NODE_V8_OPTIONS) #if defined(NODE_V8_OPTIONS)
// Should come before the call to V8::SetFlagsFromCommandLine() // Should come before the call to V8::SetFlagsFromCommandLine()
@ -4054,11 +4055,8 @@ static void StartNodeInstance(void* arg) {
env->set_trace_sync_io(trace_sync_io); env->set_trace_sync_io(trace_sync_io);
// Enable debugger // Enable debugger
if (instance_data->use_debug_agent()) { if (instance_data->use_debug_agent())
EnableDebug(env); EnableDebug(env);
} else {
uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
}
{ {
SealHandleScope seal(isolate); SealHandleScope seal(isolate);