1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

console: use 'label' argument for time and timeEnd

Browse Source 
Turns out the argument is actually called label in the console spec,
while being wrongly named on MDN. This reverts commit
8c043c12456d9b5a500f9cefcca27a61a1a381cf.

MDN has been updated in:

https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571
https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987

PR-URL: https://github.com/nodejs/node/pull/3590
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Roman Reiss 2015-10-29 20:22:12 +01:00
parent 1bacf37ef8
commit 9aee2c0e26
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/api/console.markdown
View File

@ -72,18 +72,18 @@ object. This is useful for inspecting large complicated objects. Defaults to
- `colors` - if `true`, then the output will be styled with ANSI color codes.
Defaults to `false`. Colors are customizable, see below.
### console.time(timerName)
### console.time(label)
Starts a timer that can be used to compute the duration of an operation. Timers
are identified by a unique name. Use the same name when you call
[`console.timeEnd()`](#console_console_timeend_timername) to stop the timer and
[`console.timeEnd()`](#console_console_timeend_label) to stop the timer and
output the elapsed time in milliseconds. Timer durations are accurate to the
sub-millisecond.
### console.timeEnd(timerName)
### console.timeEnd(label)
Stops a timer that was previously started by calling
[`console.time()`](#console_console_time_timername) and prints the result to the
[`console.time()`](#console_console_time_label) and prints the result to the
console.
Example:

12
lib/console.js
View File

@ -55,19 +55,19 @@ Console.prototype.dir = function(object, options) {
};
Console.prototype.time = function(timerName) {
this._times.set(timerName, process.hrtime());
Console.prototype.time = function(label) {
this._times.set(label, process.hrtime());
};
Console.prototype.timeEnd = function(timerName) {
var time = this._times.get(timerName);
Console.prototype.timeEnd = function(label) {
var time = this._times.get(label);
if (!time) {
throw new Error('No such timer name: ' + timerName);
throw new Error('No such label: ' + label);
}
const duration = process.hrtime(time);
const ms = duration[0] * 1000 + duration[1] / 1e6;
this.log('%s: %sms', timerName, ms.toFixed(3));
this.log('%s: %sms', label, ms.toFixed(3));
};