1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-vm-sigint

Browse Source 
* Use common.mustNotCall() to confirm SIGINT listeners are not being
  invoked.
* Improve assertion check on integer child argument.
* Add blank line per test writing guide.

PR-URL: https://github.com/nodejs/node/pull/13902
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-06-24 15:47:38 -07:00
parent 62947916b6
commit 99dc9d03de
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/parallel/test-vm-sigint.js
View File

@ -1,5 +1,6 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const vm = require('vm'); const vm = require('vm');
@ -15,7 +16,7 @@ if (process.argv[2] === 'child') {
const method = process.argv[3]; const method = process.argv[3];
const listeners = +process.argv[4]; const listeners = +process.argv[4];
assert.ok(method); assert.ok(method);
assert.ok(typeof listeners, 'number'); assert.ok(Number.isInteger(listeners));
const script = `process.send('${method}'); while(true) {}`; const script = `process.send('${method}'); while(true) {}`;
const args = method === 'runInContext' ? const args = method === 'runInContext' ?
@ -24,7 +25,7 @@ if (process.argv[2] === 'child') {
const options = { breakOnSigint: true }; const options = { breakOnSigint: true };
for (let i = 0; i < listeners; i++) for (let i = 0; i < listeners; i++)
process.on('SIGINT', common.noop); process.on('SIGINT', common.mustNotCall());
assert.throws(() => { vm[method](script, ...args, options); }, assert.throws(() => { vm[method](script, ...args, options); },
/^Error: Script execution interrupted\.$/); /^Error: Script execution interrupted\.$/);