From 99d56a4749e7b167b4f312a4fbcc754b7a3a8894 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Wed, 25 Apr 2018 22:47:56 -0700
Subject: [PATCH] console: fix console.table() display edge case

If the properties are not specified in `console.table()`, then we should
make a best effort to determine them rather than put all values into a
"Values" column.

PR-URL: https://github.com/nodejs/node/pull/20323
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/console.js                      |  4 +---
 test/parallel/test-console-table.js | 31 +++++++++++++++++++----------
 2 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/lib/console.js b/lib/console.js
index 39bcf701bf8..a0158ec6643 100644
--- a/lib/console.js
+++ b/lib/console.js
@@ -363,9 +363,7 @@ Console.prototype.table = function(tabularData, properties) {
     tabularData = previewSetIterator(tabularData);
 
   const setlike = setIter || isSet(tabularData);
-  if (setlike ||
-      (properties === undefined &&
-       (isArray(tabularData) || isTypedArray(tabularData)))) {
+  if (setlike) {
     const values = [];
     let length = 0;
     for (const v of tabularData) {
diff --git a/test/parallel/test-console-table.js b/test/parallel/test-console-table.js
index 39e9099dd71..64e2533f175 100644
--- a/test/parallel/test-console-table.js
+++ b/test/parallel/test-console-table.js
@@ -41,13 +41,13 @@ test([1, 2, 3], `
 `);
 
 test([Symbol(), 5, [10]], `
-┌─────────┬──────────┐
-│ (index) │  Values  │
-├─────────┼──────────┤
-│    0    │ Symbol() │
-│    1    │    5     │
-│    2    │  [ 10 ]  │
-└─────────┴──────────┘
+┌─────────┬────┬──────────┐
+│ (index) │ 0  │  Values  │
+├─────────┼────┼──────────┤
+│    0    │    │ Symbol() │
+│    1    │    │    5     │
+│    2    │ 10 │          │
+└─────────┴────┴──────────┘
 `);
 
 test([undefined, 5], `
@@ -182,10 +182,10 @@ test({ a: undefined }, ['x'], `
 `);
 
 test([], `
-┌─────────┬────────┐
-│ (index) │ Values │
-├─────────┼────────┤
-└─────────┴────────┘
+┌─────────┐
+│ (index) │
+├─────────┤
+└─────────┘
 `);
 
 test(new Map(), `
@@ -194,3 +194,12 @@ test(new Map(), `
 ├───────────────────┼─────┼────────┤
 └───────────────────┴─────┴────────┘
 `);
+
+test([{ a: 1, b: 'Y' }, { a: 'Z', b: 2 }], `
+┌─────────┬─────┬─────┐
+│ (index) │  a  │  b  │
+├─────────┼─────┼─────┤
+│    0    │  1  │ 'Y' │
+│    1    │ 'Z' │  2  │
+└─────────┴─────┴─────┘
+`);