1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: increase slop limit in memory leak test

Browse Source 
It transpires that the extra bookkeeping in debug builds sometimes makes
the increase in RSS go _just_ over the 5 MB limit, by fewer than 100 kB.
Double the limit so we hopefully don't run into it any time again soon.

The memory leak it tests for was one where RSS grew by hundreds of
megabytes over the lifetime of the test; 5 vs. 10 MB is insignificant.

Fixes: https://github.com/nodejs/node/issues/21076

PR-URL: https://github.com/nodejs/node/pull/21080
Refs: https://github.com/nodejs/node/issues/21076
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Ben Noordhuis 2018-06-02 10:03:25 +02:00 committed by Rich Trott
parent b557a3bedd
commit 997e97d9cd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-crypto-dh-leak.js
View File

@ -23,4 +23,4 @@ const after = process.memoryUsage().rss;
// RSS should stay the same, ceteris paribus, but allow for // RSS should stay the same, ceteris paribus, but allow for
// some slop because V8 mallocs memory during execution. // some slop because V8 mallocs memory during execution.
assert(after - before < 5 << 20, `before=${before} after=${after}`); assert(after - before < 10 << 20, `before=${before} after=${after}`);