1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

assert: remove unreachable code

Browse Source 
In lib/internal/assert/assertion_error.js, line 391 assures that
`operator` is 'deepEqual' so there is no need to check the value of
`operator` in a ternary on the next line (line 392). Remove the ternary.

PR-URL: https://github.com/nodejs/node/pull/27786
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2019-05-20 16:27:37 -07:00
parent 60b315c064
commit 99268b1e99
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/internal/assert/assertion_error.js
View File

@ -374,9 +374,9 @@ class AssertionError extends Error {
} else { } else {
let res = inspectValue(actual); let res = inspectValue(actual);
let other = inspectValue(expected); let other = inspectValue(expected);
const knownOperators = kReadableOperator[operator]; const knownOperator = kReadableOperator[operator];
if (operator === 'notDeepEqual' && res === other) { if (operator === 'notDeepEqual' && res === other) {
res = `${knownOperators}\n\n${res}`; res = `${knownOperator}\n\n${res}`;
if (res.length > 1024) { if (res.length > 1024) {
res = `${res.slice(0, 1021)}...`; res = `${res.slice(0, 1021)}...`;
} }
@ -389,8 +389,7 @@ class AssertionError extends Error {
other = `${other.slice(0, 509)}...`; other = `${other.slice(0, 509)}...`;
} }
if (operator === 'deepEqual') { if (operator === 'deepEqual') {
const eq = operator === 'deepEqual' ? 'deep-equal' : 'equal'; res = `${knownOperator}\n\n${res}\n\nshould loosely deep-equal\n\n`;
res = `${knownOperators}\n\n${res}\n\nshould loosely ${eq}\n\n`;
} else { } else {
const newOperator = kReadableOperator[`${operator}Unequal`]; const newOperator = kReadableOperator[`${operator}Unequal`];
if (newOperator) { if (newOperator) {