1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix race in test-http2-origin

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Alba Mendez 2019-07-30 22:06:46 +02:00 committed by Rich Trott
parent ab155335bc
commit 985c5f5b7e
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-http2-origin.js
View File

@ -88,7 +88,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
['https://example.org', 'https://example.com'] ['https://example.org', 'https://example.com']
]; ];
const countdown = new Countdown(2, () => { const countdown = new Countdown(3, () => {
client.close(); client.close();
server.close(); server.close();
}); });
@ -101,7 +101,7 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
countdown.dec(); countdown.dec();
}, 2)); }, 2));
client.request().on('close', mustCall()).resume(); client.request().on('close', mustCall(() => countdown.dec())).resume();
})); }));
} }
@ -119,15 +119,19 @@ const ca = readKey('fake-startcom-root-cert.pem', 'binary');
const originSet = [`https://localhost:${server.address().port}`]; const originSet = [`https://localhost:${server.address().port}`];
const client = connect(originSet[0], { ca }); const client = connect(originSet[0], { ca });
const countdown = new Countdown(2, () => {
client.close();
server.close();
});
client.on('origin', mustCall((origins) => { client.on('origin', mustCall((origins) => {
originSet.push(...check); originSet.push(...check);
deepStrictEqual(client.originSet, originSet); deepStrictEqual(client.originSet, originSet);
deepStrictEqual(origins, check); deepStrictEqual(origins, check);
client.close(); countdown.dec();
server.close();
})); }));
client.request().on('close', mustCall()).resume(); client.request().on('close', mustCall(() => countdown.dec())).resume();
})); }));
} }