1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: cover more nextTick() code

Browse Source 
The benchmarks for `process.nextTick()` do not cover the `default` case
in the internal code's `switch` statement where the callback receives
more than 3 arguments. Modify two of the benchmarks to include this
condition.

PR-URL: https://github.com/nodejs/node/pull/14645
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Rich Trott 2017-08-05 22:08:59 -07:00
parent a253704446
commit 97c43940c8
2 changed files with 30 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
benchmark/process/next-tick-breadth-args.js
View File

@ -24,10 +24,17 @@ function main(conf) {
if (n === N) if (n === N)
bench.end(n / 1e6); bench.end(n / 1e6);
} }
function cb4(arg1, arg2, arg3, arg4) {
n++;
if (n === N)
bench.end(n / 1e6);
}
bench.start(); bench.start();
for (var i = 0; i < N; i++) { for (var i = 0; i < N; i++) {
if (i % 3 === 0) if (i % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (i % 3 === 0)
process.nextTick(cb3, 512, true, null); process.nextTick(cb3, 512, true, null);
else if (i % 2 === 0) else if (i % 2 === 0)
process.nextTick(cb2, false, 5.1); process.nextTick(cb2, false, 5.1);

25
benchmark/process/next-tick-depth-args.js
View File

@ -10,9 +10,24 @@ process.maxTickDepth = Infinity;
function main(conf) { function main(conf) {
var n = +conf.millions * 1e6; var n = +conf.millions * 1e6;
function cb4(arg1, arg2, arg3, arg4) {
if (--n) {
if (n % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0)
process.nextTick(cb2, false, 5.1);
else
process.nextTick(cb1, 0);
} else
bench.end(+conf.millions);
}
function cb3(arg1, arg2, arg3) { function cb3(arg1, arg2, arg3) {
if (--n) { if (--n) {
if (n % 3 === 0) if (n % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
process.nextTick(cb3, 512, true, null); process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0) else if (n % 2 === 0)
process.nextTick(cb2, false, 5.1); process.nextTick(cb2, false, 5.1);
@ -23,7 +38,9 @@ function main(conf) {
} }
function cb2(arg1, arg2) { function cb2(arg1, arg2) {
if (--n) { if (--n) {
if (n % 3 === 0) if (n % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
process.nextTick(cb3, 512, true, null); process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0) else if (n % 2 === 0)
process.nextTick(cb2, false, 5.1); process.nextTick(cb2, false, 5.1);
@ -34,7 +51,9 @@ function main(conf) {
} }
function cb1(arg1) { function cb1(arg1) {
if (--n) { if (--n) {
if (n % 3 === 0) if (n % 4 === 0)
process.nextTick(cb4, 3.14, 1024, true, false);
else if (n % 3 === 0)
process.nextTick(cb3, 512, true, null); process.nextTick(cb3, 512, true, null);
else if (n % 2 === 0) else if (n % 2 === 0)
process.nextTick(cb2, false, 5.1); process.nextTick(cb2, false, 5.1);