1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: replaces assert.throws() with common.expectsError()

Browse Source 
replaces assert.throws() with common.expectsError() to check error code
and error type in parallel/test-buffer-alloc.js

PR-URL: https://github.com/nodejs/node/pull/22689
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Saud Khanzada 2018-09-04 20:04:19 +05:00 committed by Rich Trott
parent 8737683ba0
commit 9782ce2575
1 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
test/parallel/test-buffer-alloc.js
View File

@ -75,16 +75,40 @@ new Buffer('', 'binary');
Buffer(0);
// try to write a 0-length string beyond the end of b
assert.throws(() => b.write('', 2048), RangeError);
common.expectsError(
() => b.write('', 2048),
{
code: 'ERR_BUFFER_OUT_OF_BOUNDS',
type: RangeError
}
);
// throw when writing to negative offset
assert.throws(() => b.write('a', -1), RangeError);
common.expectsError(
() => b.write('a', -1),
{
code: 'ERR_BUFFER_OUT_OF_BOUNDS',
type: RangeError
}
);
// throw when writing past bounds from the pool
assert.throws(() => b.write('a', 2048), RangeError);
common.expectsError(
() => b.write('a', 2048),
{
code: 'ERR_BUFFER_OUT_OF_BOUNDS',
type: RangeError
}
);
// throw when writing to negative offset
assert.throws(() => b.write('a', -1), RangeError);
common.expectsError(
() => b.write('a', -1),
{
code: 'ERR_BUFFER_OUT_OF_BOUNDS',
type: RangeError
}
);
// try to copy 0 bytes worth of data into an empty buffer
b.copy(Buffer.alloc(0), 0, 0, 0);