1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: turn key length exception into CHECK

Browse Source 
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: https://github.com/nodejs/node/pull/15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ben Noordhuis 2017-08-27 06:31:59 +02:00 committed by James M Snell
parent ca78180a68
commit 964beed2f2
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/node_crypto.cc
View File

@ -3352,10 +3352,7 @@ void CipherBase::Init(const char* cipher_type,
if (mode == EVP_CIPH_WRAP_MODE)
EVP_CIPHER_CTX_set_flags(&ctx_, EVP_CIPHER_CTX_FLAG_WRAP_ALLOW);
if (!EVP_CIPHER_CTX_set_key_length(&ctx_, key_len)) {
EVP_CIPHER_CTX_cleanup(&ctx_);
return env()->ThrowError("Invalid key length");
}
CHECK_EQ(1, EVP_CIPHER_CTX_set_key_length(&ctx_, key_len));
EVP_CipherInit_ex(&ctx_,
nullptr,