1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: fix undefined error in parser event

Browse Source 
The current check for socket.server[kIncomingMessage] does not
account for the possibility of a socket.server that doesn't
have that property defined. Fix it.

PR-URL: https://github.com/nodejs/node/pull/20029
Fixes: https://github.com/nodejs/node/issues/19231
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Khaidi Chu <i@2333.moe>
This commit is contained in:
Anatoli Papirovski 2018-04-14 14:01:13 +02:00
parent 4f2000f9fe
commit 95fafc0254
No known key found for this signature in database
GPG Key ID: 614E2E1ABEB4B2C0
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/_http_common.js
View File

@ -62,7 +62,8 @@ function parserOnHeaders(headers, url) {
function parserOnHeadersComplete(versionMajor, versionMinor, headers, method, function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
url, statusCode, statusMessage, upgrade, url, statusCode, statusMessage, upgrade,
shouldKeepAlive) { shouldKeepAlive) {
var parser = this; const parser = this;
const { socket } = parser;
if (!headers) { if (!headers) {
headers = parser._headers; headers = parser._headers;
@ -75,10 +76,11 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
} }
// Parser is also used by http client // Parser is also used by http client
var ParserIncomingMessage = parser.socket && parser.socket.server ? const ParserIncomingMessage = (socket && socket.server &&
parser.socket.server[kIncomingMessage] : IncomingMessage; socket.server[kIncomingMessage]) ||
IncomingMessage;
parser.incoming = new ParserIncomingMessage(parser.socket); parser.incoming = new ParserIncomingMessage(socket);
parser.incoming.httpVersionMajor = versionMajor; parser.incoming.httpVersionMajor = versionMajor;
parser.incoming.httpVersionMinor = versionMinor; parser.incoming.httpVersionMinor = versionMinor;
parser.incoming.httpVersion = `${versionMajor}.${versionMinor}`; parser.incoming.httpVersion = `${versionMajor}.${versionMinor}`;