1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: reduce sequential/test-fs-watch flakiness

Browse Source 
The fs.watch test's write events sometimes aren't produced on OS X,
possibly because of a fsevents race condition. This patch gives delays
the writing a total of 20ms, which makes the test pass consistently.

PR-URL: https://github.com/iojs/io.js/pull/1275
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Roman Reiss 2015-03-26 20:01:17 +01:00
parent 36f017afaf
commit 955c1508da
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/sequential/test-fs-watch.js
View File

@ -56,7 +56,7 @@ assert.doesNotThrow(
setTimeout(function() { setTimeout(function() {
fs.writeFileSync(filepathOne, 'world'); fs.writeFileSync(filepathOne, 'world');
}, 10); }, 20);
process.chdir(testDir); process.chdir(testDir);
@ -79,7 +79,7 @@ assert.doesNotThrow(
setTimeout(function() { setTimeout(function() {
fs.writeFileSync(filepathTwoAbs, 'pardner'); fs.writeFileSync(filepathTwoAbs, 'pardner');
}, 10); }, 20);
try { fs.unlinkSync(filepathThree); } catch (e) {} try { fs.unlinkSync(filepathThree); } catch (e) {}
try { fs.mkdirSync(testsubdir, 0700); } catch (e) {} try { fs.mkdirSync(testsubdir, 0700); } catch (e) {}
@ -103,7 +103,7 @@ assert.doesNotThrow(
setTimeout(function() { setTimeout(function() {
var fd = fs.openSync(filepathThree, 'w'); var fd = fs.openSync(filepathThree, 'w');
fs.closeSync(fd); fs.closeSync(fd);
}, 10); }, 20);
// https://github.com/joyent/node/issues/2293 - non-persistent watcher should // https://github.com/joyent/node/issues/2293 - non-persistent watcher should
// not block the event loop // not block the event loop