test: correct assertion argument order

This conforms assertions to follow the argument order of
asserted then actual, and adds more explicit messages
to describe assertion failures.

PR-URL: https://github.com/nodejs/node/pull/23618
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
Jeff Marvin 2018-10-12 11:47:03 -07:00 committed by Ruben Bridgewater
parent 5726173021
commit 955148ab00
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762

View File

@ -8,7 +8,12 @@ const assert = require('assert');
const { NodeInstance } = require('../common/inspector-helper.js'); const { NodeInstance } = require('../common/inspector-helper.js');
function checkListResponse(response) { function checkListResponse(response) {
assert.strictEqual(1, response.length); const expectedLength = 1;
assert.strictEqual(
response.length,
expectedLength,
`Expected response length ${response.length} to be ${expectedLength}.`
);
assert.ok(response[0].devtoolsFrontendUrl); assert.ok(response[0].devtoolsFrontendUrl);
assert.ok( assert.ok(
/ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/ /ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/
@ -41,7 +46,11 @@ function assertScopeValues({ result }, expected) {
for (const actual of result) { for (const actual of result) {
const value = expected[actual.name]; const value = expected[actual.name];
if (value) { if (value) {
assert.strictEqual(value, actual.value.value); assert.strictEqual(
actual.value.value,
value,
`Expected scope values to be ${actual.value.value} instead of ${value}.`
);
unmatched.delete(actual.name); unmatched.delete(actual.name);
} }
} }
@ -117,15 +126,24 @@ async function testBreakpoint(session) {
'generatePreview': true 'generatePreview': true
} }
}); });
const expectedEvaluation = 1002;
assert.strictEqual(1002, result.value); assert.strictEqual(
result.value,
expectedEvaluation,
`Expected evaluation to be ${expectedEvaluation}, got ${result.value}.`
);
result = (await session.send({ result = (await session.send({
'method': 'Runtime.evaluate', 'params': { 'method': 'Runtime.evaluate', 'params': {
'expression': '5 * 5' 'expression': '5 * 5'
} }
})).result; })).result;
assert.strictEqual(25, result.value); const expectedResult = 25;
assert.strictEqual(
result.value,
expectedResult,
`Expected Runtime.evaluate to be ${expectedResult}, got ${result.value}.`
);
} }
async function testI18NCharacters(session) { async function testI18NCharacters(session) {
@ -288,7 +306,13 @@ async function runTest() {
await testI18NCharacters(session); await testI18NCharacters(session);
await testCommandLineAPI(session); await testCommandLineAPI(session);
await session.runToCompletion(); await session.runToCompletion();
assert.strictEqual(55, (await child.expectShutdown()).exitCode); const expectedExitCode = 55;
const { exitCode } = await child.expectShutdown();
assert.strictEqual(
exitCode,
expectedExitCode,
`Expected exit code to be ${expectedExitCode} but got ${expectedExitCode}.`
);
} }
runTest(); runTest();