1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: add common.mustCall() to NAPI exception test

Browse Source 
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: https://github.com/nodejs/node/pull/12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2017-05-10 19:37:25 -07:00
parent 84fc069b95
commit 9516aa19c1
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/addons-napi/test_exception/test.js
View File

@ -9,8 +9,6 @@ function throwTheError() {
} }
let caughtError; let caughtError;
const throwNoError = common.noop;
// Test that the native side successfully captures the exception // Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError); let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError, assert.strictEqual(theError, returnedError,
@ -34,13 +32,13 @@ assert.strictEqual(test_exception.wasPending(), true,
' when it was allowed through'); ' when it was allowed through');
// Test that the native side does not capture a non-existing exception // Test that the native side does not capture a non-existing exception
returnedError = test_exception.returnException(throwNoError); returnedError = test_exception.returnException(common.mustCall());
assert.strictEqual(undefined, returnedError, assert.strictEqual(undefined, returnedError,
'Returned error is undefined when no exception is thrown'); 'Returned error is undefined when no exception is thrown');
// Test that no exception appears that was not thrown by us // Test that no exception appears that was not thrown by us
try { try {
test_exception.allowException(throwNoError); test_exception.allowException(common.mustCall());
} catch (anError) { } catch (anError) {
caughtError = anError; caughtError = anError;
} }