1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: kill subprocess only after last ACK

Browse Source 
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: https://github.com/nodejs/node/pull/15186
Fixes: https://github.com/nodejs/node/issues/15176
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Refael Ackermann 2017-09-04 11:18:54 -04:00
parent 668ad44922
commit 94be2b1793
No known key found for this signature in database
GPG Key ID: CD704BD80FDDDB64
1 changed files with 47 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
test/parallel/test-child-process-send-returns-boolean.js
View File

@ -1,28 +1,58 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
// subprocess.send() will return false if the channel has closed or when the
// backlog of unsent messages exceeds a threshold that makes it unwise to send
// more. Otherwise, the method returns true.
const assert = require('assert'); const assert = require('assert');
const net = require('net'); const net = require('net');
const { fork, spawn } = require('child_process'); const { fork, spawn } = require('child_process');
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
const emptyFile = fixtures.path('empty.js'); // Just a script that stays alive (does not listen to `process.on('message')`).
const subScript = fixtures.path('child-process-persistent.js');
const n = fork(emptyFile); {
// Test `send` return value on `fork` that opens and IPC by deafult.
const n = fork(subScript);
// `subprocess.send` should always return `true` for the first send.
const rv = n.send({ h: 'w' }, (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv, true);
n.kill();
}
const rv = n.send({ hello: 'world' }); {
assert.strictEqual(rv, true); // Test `send` return value on `spawn` and saturate backlog with handles.
// Call `spawn` with options that open an IPC channel.
const spawnOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] };
const s = spawn(process.execPath, [subScript], spawnOptions);
const spawnOptions = { stdio: ['pipe', 'pipe', 'pipe', 'ipc'] }; const server = net.createServer(common.mustNotCall()).listen(0, () => {
const s = spawn(process.execPath, [emptyFile], spawnOptions); const handle = server._handle;
let handle = null;
s.on('exit', function() {
handle.close();
});
net.createServer(common.mustNotCall()).listen(0, function() { // Sending a handle and not giving the tickQueue time to acknoladge should
handle = this._handle; // create the internal backlog, but leave it empty.
assert.strictEqual(s.send('one', handle), true); const rv1 = s.send('one', handle, (err) => { if (err) assert.fail(err); });
assert.strictEqual(s.send('two', handle), true); assert.strictEqual(rv1, true);
assert.strictEqual(s.send('three'), false); // Since the first `send` included a handle (should be unackoladged),
assert.strictEqual(s.send('four'), false); // we can safly queue up only one more message.
}); const rv2 = s.send('two', (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv2, true);
// The backlog should now be indicate to backoff.
const rv3 = s.send('three', (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv3, false);
const rv4 = s.send('four', (err) => {
if (err) assert.fail(err);
// `send` queue should have been drained.
const rv5 = s.send('5', handle, (err) => { if (err) assert.fail(err); });
assert.strictEqual(rv5, true);
// End test and cleanup.
s.kill();
handle.close();
server.close();
});
assert.strictEqual(rv4, false);
});
}