1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: don't concatenate strings in debug logging

Browse Source 
Not necessary, not a good idea.

PR-URL: https://github.com/nodejs/node/pull/12342
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Ben Noordhuis 2017-04-11 17:31:54 +02:00
parent 571882c5a4
commit 9433434461
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/net.js
View File

@ -1007,7 +1007,7 @@ function lookupAndConnect(self, options) {
dnsopts.hints = dns.ADDRCONFIG; dnsopts.hints = dns.ADDRCONFIG;
} }
debug('connect: find host ' + host); debug('connect: find host', host);
debug('connect: dns options', dnsopts); debug('connect: dns options', dnsopts);
self._host = host; self._host = host;
var lookup = options.lookup || dns.lookup; var lookup = options.lookup || dns.lookup;
@ -1183,7 +1183,7 @@ function createServerHandle(address, port, addressType, fd) {
handle = createHandle(fd); handle = createHandle(fd);
} catch (e) { } catch (e) {
// Not a fd we can listen on. This will trigger an error. // Not a fd we can listen on. This will trigger an error.
debug('listen invalid fd=' + fd + ': ' + e.message); debug('listen invalid fd=%d:', fd, e.message);
return uv.UV_EINVAL; return uv.UV_EINVAL;
} }
handle.open(fd); handle.open(fd);
@ -1204,7 +1204,7 @@ function createServerHandle(address, port, addressType, fd) {
} }
if (address || port || isTCP) { if (address || port || isTCP) {
debug('bind to ' + (address || 'anycast')); debug('bind to', address || 'any');
if (!address) { if (!address) {
// Try binding to ipv6 first // Try binding to ipv6 first
err = handle.bind6('::', port); err = handle.bind6('::', port);