test,buffer: refactor redeclarations

Many variables in the buffer tests are redeclared. Change them so that
they are scoped appropriately.

PR-URL: https://github.com/nodejs/node/pull/4893
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

test/parallel/test-buffer-includes.js

@@ -161,7 +161,7 @@ assert(!mixedByteStringUtf8.includes('\u0396'));
 // Test complex string includes algorithms. Only trigger for long strings.
 // Long string that isn't a simple repeat of a shorter string.
 var longString = 'A';
-for (var i = 66; i < 76; i++) {  // from 'B' to 'K'
+for (let i = 66; i < 76; i++) {  // from 'B' to 'K'
   longString =  longString + String.fromCharCode(i) + longString;
 }
 
@@ -169,7 +169,7 @@ const longBufferString = new Buffer(longString);
 
 // pattern of 15 chars, repeated every 16 chars in long
 var pattern = 'ABACABADABACABA';
-for (var i = 0; i < longBufferString.length - pattern.length; i += 7) {
+for (let i = 0; i < longBufferString.length - pattern.length; i += 7) {
   const includes = longBufferString.includes(pattern, i);
   assert(includes, 'Long ABACABA...-string at index ' + i);
 }
@@ -188,7 +188,7 @@ assert(asciiString.includes('leb', 0));
 
 // Search in string containing many non-ASCII chars.
 const allCodePoints = [];
-for (var i = 0; i < 65536; i++) allCodePoints[i] = i;
+for (let i = 0; i < 65536; i++) allCodePoints[i] = i;
 const allCharsString = String.fromCharCode.apply(String, allCodePoints);
 const allCharsBufferUtf8 = new Buffer(allCharsString);
 const allCharsBufferUcs2 = new Buffer(allCharsString, 'ucs2');
@@ -201,10 +201,10 @@ assert(!allCharsBufferUcs2.includes('notfound'));
 // Find substrings in Utf8.
 var lengths = [1, 3, 15];  // Single char, simple and complex.
 var indices = [0x5, 0x60, 0x400, 0x680, 0x7ee, 0xFF02, 0x16610, 0x2f77b];
-for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
+for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
-  for (var i = 0; i < indices.length; i++) {
+  for (let i = 0; i < indices.length; i++) {
     const index = indices[i];
-    var length = lengths[lengthIndex];
+    let length = lengths[lengthIndex];
 
     if (index + length > 0x7F) {
       length = 2 * length;
@@ -229,10 +229,10 @@ for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
 // Find substrings in Usc2.
 lengths = [2, 4, 16];  // Single char, simple and complex.
 indices = [0x5, 0x65, 0x105, 0x205, 0x285, 0x2005, 0x2085, 0xfff0];
-for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
+for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
-  for (var i = 0; i < indices.length; i++) {
+  for (let i = 0; i < indices.length; i++) {
     const index = indices[i] * 2;
-    var length = lengths[lengthIndex];
+    const length = lengths[lengthIndex];
 
     const patternBufferUcs2 =
         allCharsBufferUcs2.slice(index, index + length);

test/parallel/test-buffer-indexof.js

@@ -124,9 +124,9 @@ assert.equal(
 assert.equal(new Buffer('aaaa0').indexOf('30', 'hex'), 4);
 assert.equal(new Buffer('aaaa00a').indexOf('3030', 'hex'), 4);
 
-
+{
   // test usc2 encoding
-var twoByteString = new Buffer('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');
+  const twoByteString = new Buffer('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');
 
   assert.equal(8, twoByteString.indexOf('\u0395', 4, 'ucs2'));
   assert.equal(6, twoByteString.indexOf('\u03a3', -4, 'ucs2'));
@@ -134,6 +134,7 @@ assert.equal(4, twoByteString.indexOf('\u03a3', -6, 'ucs2'));
   assert.equal(4, twoByteString.indexOf(
     new Buffer('\u03a3', 'ucs2'), -6, 'ucs2'));
   assert.equal(-1, twoByteString.indexOf('\u03a3', -2, 'ucs2'));
+}
 
 var mixedByteStringUcs2 =
     new Buffer('\u039a\u0391abc\u03a3\u03a3\u0395', 'ucs2');
@@ -148,7 +149,8 @@ assert.equal(
 assert.equal(
     -1, mixedByteStringUcs2.indexOf(new Buffer('\u0396', 'ucs2'), 0, 'ucs2'));
 
-var twoByteString = new Buffer('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');
+{
+  const twoByteString = new Buffer('\u039a\u0391\u03a3\u03a3\u0395', 'ucs2');
 
   // Test single char pattern
   assert.equal(0, twoByteString.indexOf('\u039a', 0, 'ucs2'));
@@ -167,6 +169,7 @@ assert.equal(
       4, twoByteString.indexOf('\u03a3\u03a3', 0, 'ucs2'), 'Sigma Sigma');
   assert.equal(
       6, twoByteString.indexOf('\u03a3\u0395', 0, 'ucs2'), 'Sigma Epsilon');
+}
 
 var mixedByteStringUtf8 = new Buffer('\u039a\u0391abc\u03a3\u03a3\u0395');
 assert.equal(5, mixedByteStringUtf8.indexOf('bc'));
@@ -179,7 +182,7 @@ assert.equal(-1, mixedByteStringUtf8.indexOf('\u0396'));
 // Test complex string indexOf algorithms. Only trigger for long strings.
 // Long string that isn't a simple repeat of a shorter string.
 var longString = 'A';
-for (var i = 66; i < 76; i++) {  // from 'B' to 'K'
+for (let i = 66; i < 76; i++) {  // from 'B' to 'K'
   longString =  longString + String.fromCharCode(i) + longString;
 }
 
@@ -187,8 +190,8 @@ var longBufferString = new Buffer(longString);
 
 // pattern of 15 chars, repeated every 16 chars in long
 var pattern = 'ABACABADABACABA';
-for (var i = 0; i < longBufferString.length - pattern.length; i += 7) {
+for (let i = 0; i < longBufferString.length - pattern.length; i += 7) {
-  var index = longBufferString.indexOf(pattern, i);
+  const index = longBufferString.indexOf(pattern, i);
   assert.equal((i + 15) & ~0xf, index, 'Long ABACABA...-string at index ' + i);
 }
 assert.equal(510, longBufferString.indexOf('AJABACA'), 'Long AJABACA, First J');
@@ -209,7 +212,7 @@ assert.equal(3, asciiString.indexOf('leb', 0));
 
 // Search in string containing many non-ASCII chars.
 var allCodePoints = [];
-for (var i = 0; i < 65536; i++) allCodePoints[i] = i;
+for (let i = 0; i < 65536; i++) allCodePoints[i] = i;
 var allCharsString = String.fromCharCode.apply(String, allCodePoints);
 var allCharsBufferUtf8 = new Buffer(allCharsString);
 var allCharsBufferUcs2 = new Buffer(allCharsString, 'ucs2');
@@ -219,13 +222,14 @@ var allCharsBufferUcs2 = new Buffer(allCharsString, 'ucs2');
 assert.equal(-1, allCharsBufferUtf8.indexOf('notfound'));
 assert.equal(-1, allCharsBufferUcs2.indexOf('notfound'));
 
+{
   // Find substrings in Utf8.
-var lengths = [1, 3, 15];  // Single char, simple and complex.
+  const lengths = [1, 3, 15];  // Single char, simple and complex.
-var indices = [0x5, 0x60, 0x400, 0x680, 0x7ee, 0xFF02, 0x16610, 0x2f77b];
+  const indices = [0x5, 0x60, 0x400, 0x680, 0x7ee, 0xFF02, 0x16610, 0x2f77b];
-for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
+  for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
-  for (var i = 0; i < indices.length; i++) {
+    for (let i = 0; i < indices.length; i++) {
-    var index = indices[i];
+      const index = indices[i];
-    var length = lengths[lengthIndex];
+      let length = lengths[lengthIndex];
 
       if (index + length > 0x7F) {
         length = 2 * length;
@@ -246,14 +250,16 @@ for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
       assert.equal(index, allCharsBufferUtf8.indexOf(patternStringUtf8));
     }
   }
+}
 
+{
   // Find substrings in Usc2.
-var lengths = [2, 4, 16];  // Single char, simple and complex.
+  const lengths = [2, 4, 16];  // Single char, simple and complex.
-var indices = [0x5, 0x65, 0x105, 0x205, 0x285, 0x2005, 0x2085, 0xfff0];
+  const indices = [0x5, 0x65, 0x105, 0x205, 0x285, 0x2005, 0x2085, 0xfff0];
-for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
+  for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
-  for (var i = 0; i < indices.length; i++) {
+    for (let i = 0; i < indices.length; i++) {
-    var index = indices[i] * 2;
+      const index = indices[i] * 2;
-    var length = lengths[lengthIndex];
+      const length = lengths[lengthIndex];
 
       var patternBufferUcs2 =
           allCharsBufferUcs2.slice(index, index + length);
@@ -265,6 +271,7 @@ for (var lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) {
           index, allCharsBufferUcs2.indexOf(patternStringUcs2, 0, 'ucs2'));
     }
   }
+}
 
 assert.throws(function() {
   b.indexOf(function() { });

test/parallel/test-buffer-iterator.js

@@ -50,7 +50,7 @@ assert.deepEqual(arr, [0, 1, 2, 3, 4]);
 
 arr = [];
 
-for (var b of buffer.entries())
+for (b of buffer.entries())
   arr.push(b);
 
 assert.deepEqual(arr, [

test/parallel/test-buffer.js

@@ -16,11 +16,11 @@ assert.strictEqual(1024, b.length);
 b[0] = -1;
 assert.strictEqual(b[0], 255);
 
-for (var i = 0; i < 1024; i++) {
+for (let i = 0; i < 1024; i++) {
   b[i] = i % 256;
 }
 
-for (var i = 0; i < 1024; i++) {
+for (let i = 0; i < 1024; i++) {
   assert.strictEqual(i % 256, b[i]);
 }
 
@@ -41,144 +41,157 @@ assert.throws(function() {
 // Make sure this doesn't hang indefinitely.
 Buffer(8).fill('');
 
-var buf = new Buffer(64);
+{
+  const buf = new Buffer(64);
   buf.fill(10);
-for (var i = 0; i < buf.length; i++)
+  for (let i = 0; i < buf.length; i++)
     assert.equal(buf[i], 10);
 
   buf.fill(11, 0, buf.length >> 1);
-for (var i = 0; i < buf.length >> 1; i++)
+  for (let i = 0; i < buf.length >> 1; i++)
     assert.equal(buf[i], 11);
-for (var i = (buf.length >> 1) + 1; i < buf.length; i++)
+  for (let i = (buf.length >> 1) + 1; i < buf.length; i++)
     assert.equal(buf[i], 10);
 
   buf.fill('h');
-for (var i = 0; i < buf.length; i++)
+  for (let i = 0; i < buf.length; i++)
     assert.equal('h'.charCodeAt(0), buf[i]);
 
   buf.fill(0);
-for (var i = 0; i < buf.length; i++)
+  for (let i = 0; i < buf.length; i++)
     assert.equal(0, buf[i]);
 
   buf.fill(null);
-for (var i = 0; i < buf.length; i++)
+  for (let i = 0; i < buf.length; i++)
     assert.equal(0, buf[i]);
 
   buf.fill(1, 16, 32);
-for (var i = 0; i < 16; i++)
+  for (let i = 0; i < 16; i++)
     assert.equal(0, buf[i]);
-for (; i < 32; i++)
+  for (let i = 16; i < 32; i++)
     assert.equal(1, buf[i]);
-for (; i < buf.length; i++)
+  for (let i = 32; i < buf.length; i++)
     assert.equal(0, buf[i]);
+}
 
-var buf = new Buffer(10);
+{
+  const buf = new Buffer(10);
   buf.fill('abc');
   assert.equal(buf.toString(), 'abcabcabca');
   buf.fill('է');
   assert.equal(buf.toString(), 'էէէէէ');
+}
 
+{
   // copy 512 bytes, from 0 to 512.
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = b.copy(c, 0, 0, 512);
+  const copied = b.copy(c, 0, 0, 512);
   console.log('copied %d bytes from b into c', copied);
   assert.strictEqual(512, copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(b[i], c[i]);
   }
+}
 
+{
   // copy c into b, without specifying sourceEnd
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = c.copy(b, 0, 0);
+  const copied = c.copy(b, 0, 0);
   console.log('copied %d bytes from c into b w/o sourceEnd', copied);
   assert.strictEqual(c.length, copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(c[i], b[i]);
   }
+}
 
+{
   // copy c into b, without specifying sourceStart
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = c.copy(b, 0);
+  const copied = c.copy(b, 0);
   console.log('copied %d bytes from c into b w/o sourceStart', copied);
   assert.strictEqual(c.length, copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(c[i], b[i]);
   }
+}
 
+{
   // copy longer buffer b to shorter c without targetStart
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = b.copy(c);
+  const copied = b.copy(c);
   console.log('copied %d bytes from b into c w/o targetStart', copied);
   assert.strictEqual(c.length, copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(b[i], c[i]);
   }
+}
 
+{
   // copy starting near end of b to c
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = b.copy(c, 0, b.length - Math.floor(c.length / 2));
+  const copied = b.copy(c, 0, b.length - Math.floor(c.length / 2));
   console.log('copied %d bytes from end of b into beginning of c', copied);
   assert.strictEqual(Math.floor(c.length / 2), copied);
-for (var i = 0; i < Math.floor(c.length / 2); i++) {
+  for (let i = 0; i < Math.floor(c.length / 2); i++) {
     assert.strictEqual(b[b.length - Math.floor(c.length / 2) + i], c[i]);
   }
-for (var i = Math.floor(c.length / 2) + 1; i < c.length; i++) {
+  for (let i = Math.floor(c.length / 2) + 1; i < c.length; i++) {
     assert.strictEqual(c[c.length - 1], c[i]);
   }
+}
 
+{
   // try to copy 513 bytes, and check we don't overrun c
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = b.copy(c, 0, 0, 513);
+  const copied = b.copy(c, 0, 0, 513);
   console.log('copied %d bytes from b trying to overrun c', copied);
   assert.strictEqual(c.length, copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(b[i], c[i]);
   }
+}
 
+{
   // copy 768 bytes from b into b
   b.fill(++cntr);
   b.fill(++cntr, 256);
-var copied = b.copy(b, 0, 256, 1024);
+  const copied = b.copy(b, 0, 256, 1024);
   console.log('copied %d bytes from b into b', copied);
   assert.strictEqual(768, copied);
-for (var i = 0; i < b.length; i++) {
+  for (let i = 0; i < b.length; i++) {
     assert.strictEqual(cntr, b[i]);
   }
+}
 
 // copy string longer than buffer length (failure will segfault)
 var bb = new Buffer(10);
 bb.fill('hello crazy world');
 
 
-var caught_error = null;
-
 // try to copy from before the beginning of b
-caught_error = null;
+assert.doesNotThrow(() => { b.copy(c, 0, 100, 10); });
-try {
-  var copied = b.copy(c, 0, 100, 10);
-} catch (err) {
-  caught_error = err;
-}
 
 // copy throws at negative sourceStart
 assert.throws(function() {
   Buffer(5).copy(Buffer(5), 0, -1);
 }, RangeError);
 
+{
   // check sourceEnd resets to targetEnd if former is greater than the latter
   b.fill(++cntr);
   c.fill(++cntr);
-var copied = b.copy(c, 0, 0, 1025);
+  const copied = b.copy(c, 0, 0, 1025);
   console.log('copied %d bytes from b into c', copied);
-for (var i = 0; i < c.length; i++) {
+  for (let i = 0; i < c.length; i++) {
     assert.strictEqual(b[i], c[i]);
   }
+}
 
 // throw with negative sourceEnd
 console.log('test copy at negative sourceEnd');
@@ -197,7 +210,7 @@ var caught_error;
 // invalid encoding for Buffer.toString
 caught_error = null;
 try {
-  var copied = b.toString('invalid');
+  b.toString('invalid');
 } catch (err) {
   caught_error = err;
 }
@@ -206,7 +219,7 @@ assert.strictEqual('Unknown encoding: invalid', caught_error.message);
 // invalid encoding for Buffer.write
 caught_error = null;
 try {
-  var copied = b.write('test string', 0, 5, 'invalid');
+  b.write('test string', 0, 5, 'invalid');
 } catch (err) {
   caught_error = err;
 }
@@ -338,26 +351,36 @@ writeTest.write('j', 'ascii', 4);
 assert.equal(writeTest.toString(), 'nodejs');
 
 // ASCII slice test
+{
+  const asciiString = 'hello world';
 
-var asciiString = 'hello world';
+  for (let i = 0; i < asciiString.length; i++) {
-var offset = 100;
-
-for (var i = 0; i < asciiString.length; i++) {
     b[i] = asciiString.charCodeAt(i);
   }
-var asciiSlice = b.toString('ascii', 0, asciiString.length);
+  const asciiSlice = b.toString('ascii', 0, asciiString.length);
   assert.equal(asciiString, asciiSlice);
+}
 
-var written = b.write(asciiString, offset, 'ascii');
+{
+  const asciiString = 'hello world';
+  const offset = 100;
+
+  const written = b.write(asciiString, offset, 'ascii');
   assert.equal(asciiString.length, written);
-var asciiSlice = b.toString('ascii', offset, offset + asciiString.length);
+  const asciiSlice = b.toString('ascii', offset, offset + asciiString.length);
   assert.equal(asciiString, asciiSlice);
+}
 
-var sliceA = b.slice(offset, offset + asciiString.length);
+{
-var sliceB = b.slice(offset, offset + asciiString.length);
+  const asciiString = 'hello world';
-for (var i = 0; i < asciiString.length; i++) {
+  const offset = 100;
+
+  const sliceA = b.slice(offset, offset + asciiString.length);
+  const sliceB = b.slice(offset, offset + asciiString.length);
+  for (let i = 0; i < asciiString.length; i++) {
     assert.equal(sliceA[i], sliceB[i]);
   }
+}
 
 // UTF-8 slice test
 
@@ -375,88 +398,109 @@ assert.equal(utf8String, utf8Slice);
 
 var sliceA = b.slice(offset, offset + Buffer.byteLength(utf8String));
 var sliceB = b.slice(offset, offset + Buffer.byteLength(utf8String));
-for (var i = 0; i < Buffer.byteLength(utf8String); i++) {
+for (let i = 0; i < Buffer.byteLength(utf8String); i++) {
   assert.equal(sliceA[i], sliceB[i]);
 }
 
-var slice = b.slice(100, 150);
+{
+  const slice = b.slice(100, 150);
   assert.equal(50, slice.length);
-for (var i = 0; i < 50; i++) {
+  for (let i = 0; i < 50; i++) {
     assert.equal(b[100 + i], slice[i]);
   }
+}
 
-
+{
   // make sure only top level parent propagates from allocPool
-var b = new Buffer(5);
+  const b = new Buffer(5);
-var c = b.slice(0, 4);
+  const c = b.slice(0, 4);
-var d = c.slice(0, 2);
+  const d = c.slice(0, 2);
   assert.equal(b.parent, c.parent);
   assert.equal(b.parent, d.parent);
+}
 
+{
   // also from a non-pooled instance
-var b = new SlowBuffer(5);
+  const b = new SlowBuffer(5);
-var c = b.slice(0, 4);
+  const c = b.slice(0, 4);
-var d = c.slice(0, 2);
+  const d = c.slice(0, 2);
-
+  assert.equal(c.parent, d.parent);
+}
 
+{
   // Bug regression test
-var testValue = '\u00F6\u65E5\u672C\u8A9E'; // ö日本語
+  const testValue = '\u00F6\u65E5\u672C\u8A9E'; // ö日本語
-var buffer = new Buffer(32);
+  const buffer = new Buffer(32);
-var size = buffer.write(testValue, 0, 'utf8');
+  const size = buffer.write(testValue, 0, 'utf8');
   console.log('bytes written to buffer: ' + size);
-var slice = buffer.toString('utf8', 0, size);
+  const slice = buffer.toString('utf8', 0, size);
   assert.equal(slice, testValue);
+}
 
-
+{
   // Test triple  slice
-var a = new Buffer(8);
+  const a = new Buffer(8);
-for (var i = 0; i < 8; i++) a[i] = i;
+  for (let i = 0; i < 8; i++) a[i] = i;
-var b = a.slice(4, 8);
+  const b = a.slice(4, 8);
   assert.equal(4, b[0]);
   assert.equal(5, b[1]);
   assert.equal(6, b[2]);
   assert.equal(7, b[3]);
-var c = b.slice(2, 4);
+  const c = b.slice(2, 4);
   assert.equal(6, c[0]);
   assert.equal(7, c[1]);
+}
 
-
+{
-var d = new Buffer([23, 42, 255]);
+  const d = new Buffer([23, 42, 255]);
   assert.equal(d.length, 3);
   assert.equal(d[0], 23);
   assert.equal(d[1], 42);
   assert.equal(d[2], 255);
   assert.deepEqual(d, new Buffer(d));
+}
 
-var e = new Buffer('über');
+{
+  const e = new Buffer('über');
   console.error('uber: \'%s\'', e.toString());
   assert.deepEqual(e, new Buffer([195, 188, 98, 101, 114]));
+}
 
-var f = new Buffer('über', 'ascii');
+{
+  const f = new Buffer('über', 'ascii');
   console.error('f.length: %d     (should be 4)', f.length);
   assert.deepEqual(f, new Buffer([252, 98, 101, 114]));
+}
 
 ['ucs2', 'ucs-2', 'utf16le', 'utf-16le'].forEach(function(encoding) {
-  var f = new Buffer('über', encoding);
+  {
+    const f = new Buffer('über', encoding);
     console.error('f.length: %d     (should be 8)', f.length);
     assert.deepEqual(f, new Buffer([252, 0, 98, 0, 101, 0, 114, 0]));
+  }
 
-  var f = new Buffer('привет', encoding);
+  {
+    const f = new Buffer('привет', encoding);
     console.error('f.length: %d     (should be 12)', f.length);
     assert.deepEqual(f, new Buffer([63, 4, 64, 4, 56, 4, 50, 4, 53, 4, 66, 4]));
     assert.equal(f.toString(encoding), 'привет');
+  }
 
-  var f = new Buffer([0, 0, 0, 0, 0]);
+  {
+    const f = new Buffer([0, 0, 0, 0, 0]);
     assert.equal(f.length, 5);
-  var size = f.write('あいうえお', encoding);
+    const size = f.write('あいうえお', encoding);
     console.error('bytes written to buffer: %d     (should be 4)', size);
     assert.equal(size, 4);
     assert.deepEqual(f, new Buffer([0x42, 0x30, 0x44, 0x30, 0x00]));
+  }
 });
 
-var f = new Buffer('\uD83D\uDC4D', 'utf-16le'); // THUMBS UP SIGN (U+1F44D)
+{
+  const f = new Buffer('\uD83D\uDC4D', 'utf-16le'); // THUMBS UP SIGN (U+1F44D)
   assert.equal(f.length, 4);
   assert.deepEqual(f, new Buffer('3DD84DDC', 'hex'));
+}
 
 
 var arrayIsh = {0: 0, 1: 1, 2: 2, 3: 3, length: 4};
@@ -472,33 +516,36 @@ assert.deepEqual(g, new Buffer([0, 1, 2, 3]));
 //
 assert.equal('TWFu', (new Buffer('Man')).toString('base64'));
 
+{
   // test that regular and URL-safe base64 both work
-var expected = [0xff, 0xff, 0xbe, 0xff, 0xef, 0xbf, 0xfb, 0xef, 0xff];
+  const expected = [0xff, 0xff, 0xbe, 0xff, 0xef, 0xbf, 0xfb, 0xef, 0xff];
   assert.deepEqual(Buffer('//++/++/++//', 'base64'), Buffer(expected));
   assert.deepEqual(Buffer('__--_--_--__', 'base64'), Buffer(expected));
+}
 
+{
   // big example
-var quote = 'Man is distinguished, not only by his reason, but by this ' +
+  const quote = 'Man is distinguished, not only by his reason, but by this ' +
               'singular passion from other animals, which is a lust ' +
-            'of the mind, that by a perseverance of delight in the continued ' +
+              'of the mind, that by a perseverance of delight in the ' +
-            'and indefatigable generation of knowledge, exceeds the short ' +
+              'continued and indefatigable generation of knowledge, exceeds ' +
-            'vehemence of any carnal pleasure.';
+              'the short vehemence of any carnal pleasure.';
-var expected = 'TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24s' +
+  const expected = 'TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb' +
-               'IGJ1dCBieSB0aGlzIHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltY' +
+                 '24sIGJ1dCBieSB0aGlzIHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBh' +
-               'WxzLCB3aGljaCBpcyBhIGx1c3Qgb2YgdGhlIG1pbmQsIHRoYXQgYnkgYSBwZX' +
+                 'bmltYWxzLCB3aGljaCBpcyBhIGx1c3Qgb2YgdGhlIG1pbmQsIHRoYXQgYnk' +
-               'JzZXZlcmFuY2Ugb2YgZGVsaWdodCBpbiB0aGUgY29udGludWVkIGFuZCBpbmR' +
+                 'gYSBwZXJzZXZlcmFuY2Ugb2YgZGVsaWdodCBpbiB0aGUgY29udGludWVkIG' +
-               'lZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Yga25vd2xlZGdlLCBleGNlZWRzIHRo' +
+                 'FuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Yga25vd2xlZGdlLCBle' +
-               'ZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCBwbGVhc3VyZS4=';
+                 'GNlZWRzIHRoZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCBwbGVh' +
+                 'c3VyZS4=';
   assert.equal(expected, (new Buffer(quote)).toString('base64'));
 
-
+  let b = new Buffer(1024);
-b = new Buffer(1024);
+  let bytesWritten = b.write(expected, 0, 'base64');
-var bytesWritten = b.write(expected, 0, 'base64');
   assert.equal(quote.length, bytesWritten);
   assert.equal(quote, b.toString('ascii', 0, quote.length));
 
   // check that the base64 decoder ignores whitespace
-var expectedWhite = expected.slice(0, 60) + ' \n' +
+  const expectedWhite = expected.slice(0, 60) + ' \n' +
                       expected.slice(60, 120) + ' \n' +
                       expected.slice(120, 180) + ' \n' +
                       expected.slice(180, 240) + ' \n' +
@@ -516,7 +563,7 @@ assert.equal(quote.length, b.length);
   assert.equal(quote, b.toString('ascii', 0, quote.length));
 
   // check that the base64 decoder ignores illegal chars
-var expectedIllegal = expected.slice(0, 60) + ' \x80' +
+  const expectedIllegal = expected.slice(0, 60) + ' \x80' +
                         expected.slice(60, 120) + ' \xff' +
                         expected.slice(120, 180) + ' \x00' +
                         expected.slice(180, 240) + ' \x98' +
@@ -525,7 +572,7 @@ var expectedIllegal = expected.slice(0, 60) + ' \x80' +
   b = new Buffer(expectedIllegal, 'base64');
   assert.equal(quote.length, b.length);
   assert.equal(quote, b.toString('ascii', 0, quote.length));
-
+}
 
 assert.equal(new Buffer('', 'base64').toString(), '');
 assert.equal(new Buffer('K', 'base64').toString(), '');
@@ -607,42 +654,47 @@ assert.equal(dot[2], 0x2e);
 assert.equal(dot[3], 0x00);
 assert.equal(dot.toString('base64'), '//4uAA==');
 
+{
   // Writing base64 at a position > 0 should not mangle the result.
   //
   // https://github.com/joyent/node/issues/402
-var segments = ['TWFkbmVzcz8h', 'IFRoaXM=', 'IGlz', 'IG5vZGUuanMh'];
+  const segments = ['TWFkbmVzcz8h', 'IFRoaXM=', 'IGlz', 'IG5vZGUuanMh'];
-var buf = new Buffer(64);
+  const b = new Buffer(64);
-var pos = 0;
+  let pos = 0;
 
-for (var i = 0; i < segments.length; ++i) {
+  for (let i = 0; i < segments.length; ++i) {
     pos += b.write(segments[i], pos, 'base64');
   }
   assert.equal(b.toString('binary', 0, pos), 'Madness?! This is node.js!');
+}
 
 // Regression test for https://github.com/nodejs/node/issues/3496.
 assert.equal(Buffer('=bad'.repeat(1e4), 'base64').length, 0);
 
+{
   // Creating buffers larger than pool size.
-var l = Buffer.poolSize + 5;
+  const l = Buffer.poolSize + 5;
-var s = '';
+  let s = '';
-for (i = 0; i < l; i++) {
+  for (let i = 0; i < l; i++) {
     s += 'h';
   }
 
-var b = new Buffer(s);
+  const b = new Buffer(s);
 
-for (i = 0; i < l; i++) {
+  for (let i = 0; i < l; i++) {
     assert.equal('h'.charCodeAt(0), b[i]);
   }
 
-var sb = b.toString();
+  const sb = b.toString();
   assert.equal(sb.length, s.length);
   assert.equal(sb, s);
+}
 
-
+{
   // Single argument slice
-b = new Buffer('abcde');
+  const b = new Buffer('abcde');
   assert.equal('bcde', b.slice(1).toString());
+}
 
 // slice(0,0).length === 0
 assert.equal(0, Buffer('hello').slice(0, 0).length);
@@ -650,7 +702,7 @@ assert.equal(0, Buffer('hello').slice(0, 0).length);
 // test hex toString
 console.log('Create hex string from buffer');
 var hexb = new Buffer(256);
-for (var i = 0; i < 256; i++) {
+for (let i = 0; i < 256; i++) {
   hexb[i] = i;
 }
 var hexStr = hexb.toString('hex');
@@ -674,19 +726,20 @@ assert.equal(hexStr,
 
 console.log('Create buffer from hex string');
 var hexb2 = new Buffer(hexStr, 'hex');
-for (var i = 0; i < 256; i++) {
+for (let i = 0; i < 256; i++) {
   assert.equal(hexb2[i], hexb[i]);
 }
 
+{
   // test an invalid slice end.
   console.log('Try to slice off the end of the buffer');
-var b = new Buffer([1, 2, 3, 4, 5]);
+  const b = new Buffer([1, 2, 3, 4, 5]);
-var b2 = b.toString('hex', 1, 10000);
+  const b2 = b.toString('hex', 1, 10000);
-var b3 = b.toString('hex', 1, 5);
+  const b3 = b.toString('hex', 1, 5);
-var b4 = b.toString('hex', 1);
+  const b4 = b.toString('hex', 1);
   assert.equal(b2, b3);
   assert.equal(b2, b4);
-
+}
 
 function buildBuffer(data) {
   if (Array.isArray(data)) {
@@ -704,7 +757,8 @@ var x = buildBuffer([0x81, 0xa3, 0x66, 0x6f, 0x6f, 0xa3, 0x62, 0x61, 0x72]);
 console.log(x.inspect());
 assert.equal('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
 
-var z = x.slice(4);
+{
+  const z = x.slice(4);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(5, z.length);
@@ -713,48 +767,60 @@ assert.equal(0xa3, z[1]);
   assert.equal(0x62, z[2]);
   assert.equal(0x61, z[3]);
   assert.equal(0x72, z[4]);
+}
 
-var z = x.slice(0);
+{
+  const z = x.slice(0);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(z.length, x.length);
+}
 
-var z = x.slice(0, 4);
+{
+  const z = x.slice(0, 4);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(4, z.length);
   assert.equal(0x81, z[0]);
   assert.equal(0xa3, z[1]);
+}
 
-var z = x.slice(0, 9);
+{
+  const z = x.slice(0, 9);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(9, z.length);
+}
 
-var z = x.slice(1, 4);
+{
+  const z = x.slice(1, 4);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(3, z.length);
   assert.equal(0xa3, z[0]);
+}
 
-var z = x.slice(2, 4);
+{
+  const z = x.slice(2, 4);
   console.log(z.inspect());
   console.log(z.length);
   assert.equal(2, z.length);
   assert.equal(0x66, z[0]);
   assert.equal(0x6f, z[1]);
+}
 
 assert.equal(0, Buffer('hello').slice(0, 0).length);
 
 ['ucs2', 'ucs-2', 'utf16le', 'utf-16le'].forEach(function(encoding) {
-  var b = new Buffer(10);
+  const b = new Buffer(10);
   b.write('あいうえお', encoding);
   assert.equal(b.toString(encoding), 'あいうえお');
 });
 
+{
   // Binary encoding should write only one byte per character.
-var b = Buffer([0xde, 0xad, 0xbe, 0xef]);
+  const b = Buffer([0xde, 0xad, 0xbe, 0xef]);
-var s = String.fromCharCode(0xffff);
+  let s = String.fromCharCode(0xffff);
   b.write(s, 0, 'binary');
   assert.equal(0xff, b[0]);
   assert.equal(0xad, b[1]);
@@ -766,15 +832,19 @@ assert.equal(0xee, b[0]);
   assert.equal(0xad, b[1]);
   assert.equal(0xbe, b[2]);
   assert.equal(0xef, b[3]);
+}
 
+{
   // #1210 Test UTF-8 string includes null character
-var buf = new Buffer('\0');
+  let buf = new Buffer('\0');
   assert.equal(buf.length, 1);
   buf = new Buffer('\0\0');
   assert.equal(buf.length, 2);
+}
 
-buf = new Buffer(2);
+{
-var written = buf.write(''); // 0byte
+  const buf = new Buffer(2);
+  let written = buf.write(''); // 0byte
   assert.equal(written, 0);
   written = buf.write('\0'); // 1byte (v8 adds null terminator)
   assert.equal(written, 1);
@@ -786,17 +856,21 @@ written = buf.write('\0あ'); // 1byte + 3bytes
   assert.equal(written, 1);
   written = buf.write('\0\0あ'); // 1byte * 2 + 3bytes
   assert.equal(written, 2);
+}
 
-buf = new Buffer(10);
+{
+  const buf = new Buffer(10);
   written = buf.write('あいう'); // 3bytes * 3 (v8 adds null terminator)
   assert.equal(written, 9);
   written = buf.write('あいう\0'); // 3bytes * 3 + 1byte
   assert.equal(written, 10);
+}
 
+{
   // #243 Test write() with maxLength
-var buf = new Buffer(4);
+  const buf = new Buffer(4);
   buf.fill(0xFF);
-var written = buf.write('abcd', 1, 2, 'utf8');
+  let written = buf.write('abcd', 1, 2, 'utf8');
   console.log(buf);
   assert.equal(written, 2);
   assert.equal(buf[0], 0xFF);
@@ -841,19 +915,23 @@ assert.equal(buf[3], 0xFF);
     assert.equal(buf[2], 0xFF);
     assert.equal(buf[3], 0xFF);
   });
+}
 
+{
   // test offset returns are correct
-var b = new Buffer(16);
+  const b = new Buffer(16);
   assert.equal(4, b.writeUInt32LE(0, 0));
   assert.equal(6, b.writeUInt16LE(0, 4));
   assert.equal(7, b.writeUInt8(0, 6));
   assert.equal(8, b.writeInt8(0, 7));
   assert.equal(16, b.writeDoubleLE(0, 8));
+}
 
+{
   // test unmatched surrogates not producing invalid utf8 output
   // ef bf bd = utf-8 representation of unicode replacement character
   // see https://codereview.chromium.org/121173009/
-buf = new Buffer('ab\ud800cd', 'utf8');
+  const buf = new Buffer('ab\ud800cd', 'utf8');
   assert.equal(buf[0], 0x61);
   assert.equal(buf[1], 0x62);
   assert.equal(buf[2], 0xef);
@@ -861,13 +939,16 @@ assert.equal(buf[3], 0xbf);
   assert.equal(buf[4], 0xbd);
   assert.equal(buf[5], 0x63);
   assert.equal(buf[6], 0x64);
+}
 
+{
   // test for buffer overrun
-buf = new Buffer([0, 0, 0, 0, 0]); // length: 5
+  const buf = new Buffer([0, 0, 0, 0, 0]); // length: 5
   var sub = buf.slice(0, 4);         // length: 4
   written = sub.write('12345', 'binary');
   assert.equal(written, 4);
   assert.equal(buf[4], 0);
+}
 
 // Check for fractional length args, junk length args, etc.
 // https://github.com/joyent/node/issues/1758
@@ -889,11 +970,13 @@ assert.equal(Buffer('13.37').length, 5);
   assert.equal(Buffer(1).write('aaaaaa', 0, 1, enc), 1);
 });
 
+{
   // Regression test, guard against buffer overrun in the base64 decoder.
-var a = Buffer(3);
+  const a = Buffer(3);
-var b = Buffer('xxx');
+  const b = Buffer('xxx');
   a.write('aaaaaaaa', 'base64');
   assert.equal(b.toString(), 'xxx');
+}
 
 // issue GH-3416
 Buffer(Buffer(0), 0, 0);
@@ -996,15 +1079,19 @@ assert.throws(function() {
 }, RangeError);
 
 // offset checks
-var buf = new Buffer(0);
+{
+  const buf = new Buffer(0);
 
   assert.throws(function() { buf.readUInt8(0); }, RangeError);
   assert.throws(function() { buf.readInt8(0); }, RangeError);
+}
 
-var buf = new Buffer([0xFF]);
+{
+  const buf = new Buffer([0xFF]);
 
   assert.equal(buf.readUInt8(0), 255);
   assert.equal(buf.readInt8(0), -1);
+}
 
 [16, 32].forEach(function(bits) {
   var buf = new Buffer(bits / 8 - 1);
@@ -1185,7 +1272,7 @@ assert.equal(buf.readInt8(0), -1);
   assert.equal(buf.slice(-5, -8), '');
   assert.equal(buf.slice(-5, -3), '56');
   assert.equal(buf.slice(-10, 10), '0123456789');
-  for (var i = 0, s = buf.toString(); i < buf.length; ++i) {
+  for (let i = 0, s = buf.toString(); i < buf.length; ++i) {
     assert.equal(buf.slice(i), s.slice(i));
     assert.equal(buf.slice(0, i), s.slice(0, i));
     assert.equal(buf.slice(-i), s.slice(-i));
@@ -1217,13 +1304,13 @@ assert.throws(function() {
 // should a) work, and b) not corrupt the source buffer.
 (function() {
   var a = [0];
-  for (var i = 0; i < 7; ++i) a = a.concat(a);
+  for (let i = 0; i < 7; ++i) a = a.concat(a);
   a = a.map(function(_, i) { return i; });
-  var b = Buffer(a);
+  const b = Buffer(a);
-  var c = Buffer(b);
+  const c = Buffer(b);
   assert.equal(b.length, a.length);
   assert.equal(c.length, a.length);
-  for (var i = 0, k = a.length; i < k; ++i) {
+  for (let i = 0, k = a.length; i < k; ++i) {
     assert.equal(a[i], i);
     assert.equal(b[i], i);
     assert.equal(c[i], i);
@@ -1255,9 +1342,10 @@ if (common.hasCrypto) {
 }
 
 // Test Compare
-var b = new Buffer(1).fill('a');
+{
-var c = new Buffer(1).fill('c');
+  const b = new Buffer(1).fill('a');
-var d = new Buffer(2).fill('aa');
+  const c = new Buffer(1).fill('c');
+  const d = new Buffer(2).fill('aa');
 
   assert.equal(b.compare(c), -1);
   assert.equal(c.compare(d), 1);
@@ -1274,6 +1362,7 @@ assert.equal(Buffer.compare(c, c), 0);
   assert.equal(Buffer.compare(Buffer(0), Buffer(0)), 0);
   assert.equal(Buffer.compare(Buffer(0), Buffer(1)), -1);
   assert.equal(Buffer.compare(Buffer(1), Buffer(0)), 1);
+}
 
 assert.throws(function() {
   var b = new Buffer(1);
@@ -1291,15 +1380,17 @@ assert.throws(function() {
 });
 
 // Test Equals
-var b = new Buffer(5).fill('abcdf');
+{
-var c = new Buffer(5).fill('abcdf');
+  const b = new Buffer(5).fill('abcdf');
-var d = new Buffer(5).fill('abcde');
+  const c = new Buffer(5).fill('abcdf');
-var e = new Buffer(6).fill('abcdef');
+  const d = new Buffer(5).fill('abcde');
+  const e = new Buffer(6).fill('abcdef');
 
   assert.ok(b.equals(c));
   assert.ok(!c.equals(d));
   assert.ok(!d.equals(e));
   assert.ok(d.equals(d));
+}
 
 assert.throws(function() {
   var b = new Buffer(1);