1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: properly order freeing resources in cctest

Browse Source 
The `IsolateData` instance is created before the `Environment` instance,
so free in reverse order.

Fixes: https://github.com/nodejs/node/issues/14206
PR-URL: https://github.com/nodejs/node/pull/14749
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit is contained in:
Anna Henningsen 2017-08-10 20:50:27 +02:00
parent b559e66252
commit 93f25f4b44
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/test_environment.cc
View File

@ -41,9 +41,9 @@ class EnvironmentTest : public NodeTestFixture {
}
~Env() {
FreeIsolateData(isolate_data_);
environment_->CleanupHandles();
FreeEnvironment(environment_);
FreeIsolateData(isolate_data_);
}
Environment* operator*() const {