1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "doc: correct vcbuild options for windows testing"

Browse Source 
This reverts commit ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.

PR-URL: https://github.com/nodejs/node/pull/10839
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This commit is contained in:
Gibson Fahnestock 2017-01-16 16:25:00 +00:00
parent 492163c74c
commit 93c4820458
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BUILDING.md
View File

@ -122,7 +122,7 @@ Prerequisites:
To run the tests: To run the tests:
```console ```console
> .\vcbuild nosign test > .\vcbuild test
``` ```
To test if Node.js was built correctly: To test if Node.js was built correctly:
@ -180,7 +180,7 @@ $ ./configure --with-intl=full-icu --download=all
##### Windows: ##### Windows:
```console ```console
> .\vcbuild nosign full-icu download-all > .\vcbuild full-icu download-all
``` ```
#### Building without Intl support #### Building without Intl support
@ -197,7 +197,7 @@ $ ./configure --without-intl
##### Windows: ##### Windows:
```console ```console
> .\vcbuild nosign without-intl > .\vcbuild without-intl
``` ```
#### Use existing installed ICU (Unix / OS X only): #### Use existing installed ICU (Unix / OS X only):
@ -240,7 +240,7 @@ First unpack latest ICU to `deps/icu`
as `deps/icu` (You'll have: `deps/icu/source/...`) as `deps/icu` (You'll have: `deps/icu/source/...`)
```console ```console
> .\vcbuild nosign full-icu > .\vcbuild full-icu
``` ```
## Building Node.js with FIPS-compliant OpenSSL ## Building Node.js with FIPS-compliant OpenSSL

6
CONTRIBUTING.md
View File

@ -170,7 +170,7 @@ $ ./configure && make -j4 test
Windows: Windows:
```text ```text
.\vcbuild nosign test > vcbuild test
``` ```
(See the [BUILDING.md](./BUILDING.md) for more details.) (See the [BUILDING.md](./BUILDING.md) for more details.)
@ -178,11 +178,11 @@ Windows:
Make sure the linter is happy and that all tests pass. Please, do not submit Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check. patches that fail either check.
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or Running `make test`/`vcbuild test` will run the linter as well unless one or
more tests fail. more tests fail.
If you want to run the linter without running tests, use If you want to run the linter without running tests, use
`make lint`/`.\vcbuild nosign jslint`. `make lint`/`vcbuild jslint`.
If you are updating tests and just want to run a single test to check it, you If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would: can use this syntax to run it exactly as the test harness would: