1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

node: remove bad fn call and check

Browse Source 
These two lines exist because of a screw up on my part while combining
MakeCallback() and MakeDomainCallback().

The reason it never broke core tests is because any paths it would have
broken were rerouted to AsyncWrap::MakeCallback(). The only case that
node::MakeCallback() handles anymore is setImmediate().

Fix: a1da024 "node, async-wrap: remove MakeDomainCallback"
PR-URL: https://github.com/nodejs/io.js/pull/2157
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Trevor Norris 2015-07-10 13:55:14 -06:00
parent 99d9d7e716
commit 93660c8b8e
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/node.cc
View File

@ -1092,8 +1092,6 @@ Handle<Value> MakeCallback(Environment* env,
return Undefined(env->isolate()); return Undefined(env->isolate());
} }
} }
env->tick_callback_function()->Call(process, 0, nullptr);
CHECK_EQ(env->context(), env->isolate()->GetCurrentContext());
if (try_catch.HasCaught()) { if (try_catch.HasCaught()) {
return Undefined(env->isolate()); return Undefined(env->isolate());