1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc,test: remove unnecessary await with return instances

Browse Source 
Remove unnecessary `await` in combination with `return` in preparation
for enabling lint rule.

PR-URL: https://github.com/nodejs/node/pull/17265
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
Rich Trott 2017-11-22 12:47:50 -08:00
parent 7850112c33
commit 929f343bb3
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/util.md
View File

@ -31,7 +31,7 @@ For example:
const util = require('util'); const util = require('util');
async function fn() { async function fn() {
return await Promise.resolve('hello world'); return 'hello world';
} }
const callbackFunction = util.callbackify(fn); const callbackFunction = util.callbackify(fn);

2
test/common/inspector-helper.js
View File

@ -390,7 +390,7 @@ class NodeInstance {
console.log('[test]', 'Connecting to a child Node process'); console.log('[test]', 'Connecting to a child Node process');
const response = await this.httpGet(null, '/json/list'); const response = await this.httpGet(null, '/json/list');
const url = response[0]['webSocketDebuggerUrl']; const url = response[0]['webSocketDebuggerUrl'];
return await this.wsHandshake(url); return this.wsHandshake(url);
} }
expectShutdown() { expectShutdown() {

10
test/parallel/test-util-callbackify.js
View File

@ -28,7 +28,7 @@ const values = [
for (const value of values) { for (const value of values) {
// Test and `async function` // Test and `async function`
async function asyncFn() { async function asyncFn() {
return await Promise.resolve(value); return value;
} }
const cbAsyncFn = callbackify(asyncFn); const cbAsyncFn = callbackify(asyncFn);
@ -70,7 +70,7 @@ const values = [
for (const value of values) { for (const value of values) {
// Test an `async function` // Test an `async function`
async function asyncFn() { async function asyncFn() {
return await Promise.reject(value); return Promise.reject(value);
} }
const cbAsyncFn = callbackify(asyncFn); const cbAsyncFn = callbackify(asyncFn);
@ -142,7 +142,7 @@ const values = [
for (const value of values) { for (const value of values) {
async function asyncFn(arg) { async function asyncFn(arg) {
assert.strictEqual(arg, value); assert.strictEqual(arg, value);
return await Promise.resolve(arg); return arg;
} }
const cbAsyncFn = callbackify(asyncFn); const cbAsyncFn = callbackify(asyncFn);
@ -183,7 +183,7 @@ const values = [
const iAmThat = { const iAmThat = {
async fn(arg) { async fn(arg) {
assert.strictEqual(this, iAmThat); assert.strictEqual(this, iAmThat);
return await Promise.resolve(arg); return arg;
}, },
}; };
iAmThat.cbFn = callbackify(iAmThat.fn); iAmThat.cbFn = callbackify(iAmThat.fn);
@ -241,7 +241,7 @@ const values = [
{ {
async function asyncFn() { async function asyncFn() {
return await Promise.resolve(42); return 42;
} }
const cb = callbackify(asyncFn); const cb = callbackify(asyncFn);