1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: getgroups() may contain duplicate GIDs

Browse Source 
Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

PR-URL: https://github.com/nodejs/node/pull/10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Sam Roberts 2016-12-21 10:16:19 -08:00
parent 84a23c7205
commit 9271a412b9
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-process-getgroups.js
View File

@ -1,21 +1,23 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert');
const exec = require('child_process').exec; // Check `id -G` and `process.getgroups()` return same groups.
if (common.isOSX) { if (common.isOSX) {
common.skip('Output of `id -G` is unreliable on Darwin.'); common.skip('Output of `id -G` is unreliable on Darwin.');
return; return;
} }
const assert = require('assert');
const exec = require('child_process').exec;
if (typeof process.getgroups === 'function') { if (typeof process.getgroups === 'function') {
const groups = process.getgroups(); const groups = unique(process.getgroups());
assert(Array.isArray(groups)); assert(Array.isArray(groups));
assert(groups.length > 0); assert(groups.length > 0);
exec('id -G', function(err, stdout) { exec('id -G', function(err, stdout) {
assert.ifError(err); assert.ifError(err);
const real_groups = stdout.match(/\d+/g).map(Number); const real_groups = unique(stdout.match(/\d+/g).map(Number));
assert.strictEqual(groups.length, real_groups.length); assert.deepStrictEqual(groups, real_groups);
check(groups, real_groups); check(groups, real_groups);
check(real_groups, groups); check(real_groups, groups);
}); });
@ -24,3 +26,7 @@ if (typeof process.getgroups === 'function') {
function check(a, b) { function check(a, b) {
for (let i = 0; i < a.length; ++i) assert.notStrictEqual(b.indexOf(a[i]), -1); for (let i = 0; i < a.length; ++i) assert.notStrictEqual(b.indexOf(a[i]), -1);
} }
function unique(groups) {
return [...new Set(groups)].sort();
}