1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: runtime-deprecate tls.convertNPNProtocols()

Browse Source 
Fixes: https://github.com/nodejs/node/issues/14602
PR-URL: https://github.com/nodejs/node/pull/19403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Ben Noordhuis 2018-03-17 05:41:41 +01:00
parent 5bfbe5ceae
commit 9204a0db6e
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/api/deprecations.md
View File

@ -971,6 +971,14 @@ initialization vectors. It is recommended to derive a key using
[`crypto.createDecipheriv()`][] to obtain the [`Cipher`][] and [`Decipher`][] [`crypto.createDecipheriv()`][] to obtain the [`Cipher`][] and [`Decipher`][]
objects respectively. objects respectively.
<a id="DEP0107"></a>
### DEP0107: tls.convertNPNProtocols()
Type: Runtime
This was an undocumented helper function not intended for use outside Node.js
core and obsoleted by the removal of NPN (Next Protocol Negotiation) support.
[`--pending-deprecation`]: cli.html#cli_pending_deprecation [`--pending-deprecation`]: cli.html#cli_pending_deprecation
[`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size [`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size
[`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array [`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array

4
lib/tls.js
View File

@ -73,7 +73,7 @@ function convertProtocols(protocols) {
return buff; return buff;
} }
exports.convertNPNProtocols = function(protocols, out) { exports.convertNPNProtocols = internalUtil.deprecate(function(protocols, out) {
// If protocols is Array - translate it into buffer // If protocols is Array - translate it into buffer
if (Array.isArray(protocols)) { if (Array.isArray(protocols)) {
out.NPNProtocols = convertProtocols(protocols); out.NPNProtocols = convertProtocols(protocols);
@ -81,7 +81,7 @@ exports.convertNPNProtocols = function(protocols, out) {
// Copy new buffer not to be modified by user. // Copy new buffer not to be modified by user.
out.NPNProtocols = Buffer.from(protocols); out.NPNProtocols = Buffer.from(protocols);
} }
}; }, 'tls.convertNPNProtocols() is deprecated.', 'DEP0107');
exports.convertALPNProtocols = function(protocols, out) { exports.convertALPNProtocols = function(protocols, out) {
// If protocols is Array - translate it into buffer // If protocols is Array - translate it into buffer