1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: increase error information in test-cli-syntax-*

Browse Source 
If there is an error, but not the error code the test expects, display
more information about the error.

PR-URL: https://github.com/nodejs/node/pull/25021
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This commit is contained in:
Rich Trott 2018-12-13 09:17:35 -08:00
parent 80ab537ee6
commit 914c49497c
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/sequential/test-cli-syntax-bad.js
View File

@ -32,7 +32,8 @@ const syntaxErrorRE = /^SyntaxError: \b/m;
const cmd = [node, ..._args].join(' '); const cmd = [node, ..._args].join(' ');
exec(cmd, common.mustCall((err, stdout, stderr) => { exec(cmd, common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err instanceof Error, true); assert.strictEqual(err instanceof Error, true);
assert.strictEqual(err.code, 1); assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);
// no stdout should be produced // no stdout should be produced
assert.strictEqual(stdout, ''); assert.strictEqual(stdout, '');

3
test/sequential/test-cli-syntax-file-not-found.js
View File

@ -33,7 +33,8 @@ const notFoundRE = /^Error: Cannot find module/m;
// stderr should have a module not found error message // stderr should have a module not found error message
assert(notFoundRE.test(stderr), `${notFoundRE} === ${stderr}`); assert(notFoundRE.test(stderr), `${notFoundRE} === ${stderr}`);
assert.strictEqual(err.code, 1); assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);
})); }));
}); });
}); });

3
test/sequential/test-cli-syntax-require.js
View File

@ -20,7 +20,8 @@ const syntaxErrorRE = /^SyntaxError: \b/m;
const cmd = [node, ...args].join(' '); const cmd = [node, ...args].join(' ');
exec(cmd, common.mustCall((err, stdout, stderr) => { exec(cmd, common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err instanceof Error, true); assert.strictEqual(err instanceof Error, true);
assert.strictEqual(err.code, 1); assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);
// no stdout should be produced // no stdout should be produced
assert.strictEqual(stdout, ''); assert.strictEqual(stdout, '');