1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix strictEqual() arguments order

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23800
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This commit is contained in:
Nolan Rigo 2018-10-20 21:56:05 +02:00 committed by Anna Henningsen
parent added1b0c5
commit 91431db9eb
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-http-upgrade-server.js
View File

@ -98,20 +98,20 @@ function test_upgrade_with_listener() {
conn.on('data', function(data) {
state++;
assert.strictEqual('string', typeof data);
assert.strictEqual(typeof data, 'string');
if (state === 1) {
assert.strictEqual('HTTP/1.1 101', data.substr(0, 12));
assert.strictEqual('WjN}|M(6', request_upgradeHead.toString('utf8'));
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 101');
assert.strictEqual(request_upgradeHead.toString('utf8'), 'WjN}|M(6');
conn.write('test', 'utf8');
} else if (state === 2) {
assert.strictEqual('test', data);
assert.strictEqual(data, 'test');
conn.write('kill', 'utf8');
}
});
conn.on('end', function() {
assert.strictEqual(2, state);
assert.strictEqual(state, 2);
conn.end();
server.removeAllListeners('upgrade');
test_upgrade_no_listener();
@ -156,8 +156,8 @@ function test_standard_http() {
});
conn.once('data', function(data) {
assert.strictEqual('string', typeof data);
assert.strictEqual('HTTP/1.1 200', data.substr(0, 12));
assert.strictEqual(typeof data, 'string');
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 200');
conn.end();
});
@ -179,6 +179,6 @@ server.listen(0, function() {
Fin.
-----------------------------------------------*/
process.on('exit', function() {
assert.strictEqual(3, requests_recv);
assert.strictEqual(3, requests_sent);
assert.strictEqual(requests_recv, 3);
assert.strictEqual(requests_sent, 3);
});