build: remove lint/dotfiles from release tarball
This removes the ability to run linting from the source tarball, rationale being that developers should use a git clone instead. Also, fix the path of removing artifacts from the openssl dependency since it now lives in `deps/openssl/openssl/`. Tarballs shrink with ~10%. PR-URL: https://github.com/nodejs/node/pull/5695 Fixes: https://github.com/nodejs/node/issues/5618 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: thefourtheye <thechargingvolcano@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
This commit is contained in:
parent
ba16a12051
commit
90a5fc20be
24
Makefile
24
Makefile
@ -211,6 +211,8 @@ test-timers:
|
|||||||
test-timers-clean:
|
test-timers-clean:
|
||||||
$(MAKE) --directory=tools clean
|
$(MAKE) --directory=tools clean
|
||||||
|
|
||||||
|
|
||||||
|
ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
|
||||||
test-v8:
|
test-v8:
|
||||||
# note: performs full test unless QUICKCHECK is specified
|
# note: performs full test unless QUICKCHECK is specified
|
||||||
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
|
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
|
||||||
@ -234,6 +236,12 @@ test-v8-benchmarks:
|
|||||||
|
|
||||||
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
|
test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
|
||||||
# runs all v8 tests
|
# runs all v8 tests
|
||||||
|
else
|
||||||
|
test-v8 test-v8-intl test-v8-benchmarks test-v8-all:
|
||||||
|
@echo "Testing v8 is not available through the source tarball."
|
||||||
|
@echo "Use the git repo instead:" \
|
||||||
|
"$ git clone https://github.com/nodejs/node.git"
|
||||||
|
endif
|
||||||
|
|
||||||
apidoc_sources = $(wildcard doc/api/*.markdown)
|
apidoc_sources = $(wildcard doc/api/*.markdown)
|
||||||
apidocs = $(addprefix out/,$(apidoc_sources:.markdown=.html)) \
|
apidocs = $(addprefix out/,$(apidoc_sources:.markdown=.html)) \
|
||||||
@ -427,12 +435,15 @@ $(TARBALL): release-only $(NODE_EXE) doc
|
|||||||
mkdir -p $(TARNAME)/doc/api
|
mkdir -p $(TARNAME)/doc/api
|
||||||
cp doc/node.1 $(TARNAME)/doc/node.1
|
cp doc/node.1 $(TARNAME)/doc/node.1
|
||||||
cp -r out/doc/api/* $(TARNAME)/doc/api/
|
cp -r out/doc/api/* $(TARNAME)/doc/api/
|
||||||
rm -rf $(TARNAME)/deps/v8/{test,samples,tools/profviz} # too big
|
rm -rf $(TARNAME)/deps/v8/{test,samples,tools/profviz,tools/run-tests.py}
|
||||||
rm -rf $(TARNAME)/doc/images # too big
|
rm -rf $(TARNAME)/doc/images # too big
|
||||||
rm -rf $(TARNAME)/deps/uv/{docs,samples,test}
|
rm -rf $(TARNAME)/deps/uv/{docs,samples,test}
|
||||||
rm -rf $(TARNAME)/deps/openssl/{doc,demos,test}
|
rm -rf $(TARNAME)/deps/openssl/openssl/{doc,demos,test}
|
||||||
rm -rf $(TARNAME)/deps/zlib/contrib # too big, unused
|
rm -rf $(TARNAME)/deps/zlib/contrib # too big, unused
|
||||||
rm -rf $(TARNAME)/.github # github issue templates
|
rm -rf $(TARNAME)/.{editorconfig,git*,mailmap}
|
||||||
|
rm -rf $(TARNAME)/tools/{eslint,eslint-rules,osx-pkg.pmdoc,pkgsrc}
|
||||||
|
rm -rf $(TARNAME)/tools/{osx-*,license-builder.sh,cpplint.py}
|
||||||
|
find $(TARNAME)/ -name ".eslint*" -maxdepth 2 | xargs rm
|
||||||
find $(TARNAME)/ -type l | xargs rm # annoying on windows
|
find $(TARNAME)/ -type l | xargs rm # annoying on windows
|
||||||
tar -cf $(TARNAME).tar $(TARNAME)
|
tar -cf $(TARNAME).tar $(TARNAME)
|
||||||
rm -rf $(TARNAME)
|
rm -rf $(TARNAME)
|
||||||
@ -610,7 +621,14 @@ CPPLINT_FILES = $(filter-out $(CPPLINT_EXCLUDE), $(wildcard \
|
|||||||
cpplint:
|
cpplint:
|
||||||
@$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
|
@$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
|
||||||
|
|
||||||
|
ifneq ("","$(wildcard tools/eslint/bin/eslint.js)")
|
||||||
lint: jslint cpplint
|
lint: jslint cpplint
|
||||||
|
else
|
||||||
|
lint:
|
||||||
|
@echo "Linting is not available through the source tarball."
|
||||||
|
@echo "Use the git repo instead:" \
|
||||||
|
"$ git clone https://github.com/nodejs/node.git"
|
||||||
|
endif
|
||||||
|
|
||||||
.PHONY: lint cpplint jslint bench clean docopen docclean doc dist distclean \
|
.PHONY: lint cpplint jslint bench clean docopen docclean doc dist distclean \
|
||||||
check uninstall install install-includes install-bin all staticlib \
|
check uninstall install install-includes install-bin all staticlib \
|
||||||
|
@ -261,10 +261,16 @@ goto jslint
|
|||||||
|
|
||||||
:jslint
|
:jslint
|
||||||
if not defined jslint goto exit
|
if not defined jslint goto exit
|
||||||
|
if not exist tools\eslint\bin\eslint.js goto no-lint
|
||||||
echo running jslint
|
echo running jslint
|
||||||
%config%\node tools\eslint\bin\eslint.js benchmark lib src test tools\doc tools\eslint-rules --rulesdir tools\eslint-rules
|
%config%\node tools\eslint\bin\eslint.js benchmark lib src test tools\doc tools\eslint-rules --rulesdir tools\eslint-rules
|
||||||
goto exit
|
goto exit
|
||||||
|
|
||||||
|
:no-lint
|
||||||
|
echo Linting is not available through the source tarball.
|
||||||
|
echo Use the git repo instead: $ git clone https://github.com/nodejs/node.git
|
||||||
|
goto exit
|
||||||
|
|
||||||
:create-msvs-files-failed
|
:create-msvs-files-failed
|
||||||
echo Failed to create vc project files.
|
echo Failed to create vc project files.
|
||||||
goto exit
|
goto exit
|
||||||
|
Loading…
x
Reference in New Issue
Block a user