1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repl: show proxies as Proxy objects

Browse Source 
Before this commit they transparently invoked their magic methods but
that sometimes throws confusing exceptions with misbehaving proxies.

This change is not wholly uncontroversial but we can always change the
default if necessary.  Let's see how it goes.

Fixes: https://github.com/nodejs/node/issues/16483
PR-URL: https://github.com/nodejs/node/pull/16485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Ben Noordhuis 2017-10-25 12:06:40 +02:00
parent 6563e56aef
commit 90a43906ab
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/repl.js
View File

@ -100,7 +100,9 @@ function hasOwnProperty(obj, prop) {
// Can overridden with custom print functions, such as `probe` or `eyes.js`.
// This is the default "writer" value if none is passed in the REPL options.
exports.writer = util.inspect;
const writer = exports.writer = (obj) => util.inspect(obj, writer.options);
writer.options =
Object.assign(util.inspect.defaultOptions, { showProxy: true });
exports._builtinLibs = internalModule.builtinLibs;
@ -373,11 +375,10 @@ function REPLServer(prompt,
}
self.useColors = !!options.useColors;
if (self.useColors && self.writer === util.inspect) {
if (self.useColors && self.writer === writer) {
// Turn on ANSI coloring.
self.writer = function(obj, showHidden, depth) {
return util.inspect(obj, showHidden, depth, true);
};
self.writer = (obj) => util.inspect(obj, self.writer.options);
self.writer.options = Object.assign(writer.options, { colors: true });
}
function filterInternalStackFrames(error, structuredStack) {

11
test/parallel/test-repl.js
View File

@ -413,6 +413,17 @@ function error_test() {
expect: `${prompt_multiline}${prompt_multiline}undefined\n${prompt_unix}`
},
// https://github.com/nodejs/node/issues/16483
{
client: client_unix, send: 'new Proxy({x:42}, {get(){throw null}});',
expect: `Proxy [ { x: 42 }, { get: [Function: get] } ]\n${prompt_unix}`
},
{
client: client_unix,
send: 'repl.writer.options.showProxy = false, new Proxy({x:42}, {});',
expect: `{ x: 42 }\n${prompt_unix}`
},
// Newline within template string maintains whitespace.
{ client: client_unix, send: '`foo \n`',
expect: `${prompt_multiline}'foo \\n'\n${prompt_unix}` },