1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: validate timeout in ClientRequest()

Browse Source 
Validate the timeout option in the ClientRequest() constructor
to prevent asynchronously thrown validation errors.

PR-URL: https://github.com/nodejs/node/pull/26214
Fixes: https://github.com/nodejs/node/issues/26143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
cjihrig 2019-02-20 10:02:46 -05:00
parent 4900863043
commit 907941d48e
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/_http_client.js
View File

@ -140,7 +140,9 @@ function ClientRequest(input, options, cb) {
var setHost = (options.setHost === undefined || Boolean(options.setHost)); var setHost = (options.setHost === undefined || Boolean(options.setHost));
this.socketPath = options.socketPath; this.socketPath = options.socketPath;
this.timeout = options.timeout;
if (options.timeout !== undefined)
this.timeout = validateTimerDuration(options.timeout, 'timeout');
var method = options.method; var method = options.method;
var methodIsString = (typeof method === 'string'); var methodIsString = (typeof method === 'string');

4
test/parallel/test-http-client-timeout-option.js
View File

@ -3,6 +3,10 @@ const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
assert.throws(() => {
http.request({ timeout: null });
}, /The "timeout" argument must be of type number/);
const options = { const options = {
method: 'GET', method: 'GET',
port: undefined, port: undefined,