1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test,worker: refactor test-worker-cleanup-handles

Browse Source 
* alphabetize require() statements for built-in modules by module name
* remove unused function argument `code` in callback
* replace common.expectsError() with assert.throws()
* remove unneeded line-wrap

PR-URL: https://github.com/nodejs/node/pull/25401
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2019-01-08 14:42:26 -08:00
parent fbab26f5ae
commit 906db44ccd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/parallel/test-worker-cleanup-handles.js
View File

@ -1,9 +1,10 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const { Worker, isMainThread, parentPort } = require('worker_threads');
const { Server } = require('net');
const fs = require('fs'); const fs = require('fs');
const { Server } = require('net');
const { Worker, isMainThread, parentPort } = require('worker_threads');
if (isMainThread) { if (isMainThread) {
const w = new Worker(__filename); const w = new Worker(__filename);
@ -12,14 +13,13 @@ if (isMainThread) {
assert.strictEqual(typeof fd_, 'number'); assert.strictEqual(typeof fd_, 'number');
fd = fd_; fd = fd_;
})); }));
w.on('exit', common.mustCall((code) => { w.on('exit', common.mustCall(() => {
if (fd === -1) { if (fd === -1) {
// This happens when server sockets don’t have file descriptors, // This happens when server sockets don’t have file descriptors,
// i.e. on Windows. // i.e. on Windows.
return; return;
} }
common.expectsError(() => fs.fstatSync(fd), assert.throws(() => fs.fstatSync(fd), { code: 'EBADF' });
{ code: 'EBADF' });
})); }));
} else { } else {
const server = new Server(); const server = new Server();