1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: increase coverage of buffer

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/11122
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
DavidCai 2017-02-03 09:47:55 +08:00 committed by James M Snell
parent 950ef82aaf
commit 901cb8cb5e
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-buffer-compare-offset.js
View File

@ -11,6 +11,7 @@ assert.strictEqual(-1, a.compare(b));
// Equivalent to a.compare(b). // Equivalent to a.compare(b).
assert.strictEqual(-1, a.compare(b, 0)); assert.strictEqual(-1, a.compare(b, 0));
assert.strictEqual(-1, a.compare(b, '0')); assert.strictEqual(-1, a.compare(b, '0'));
assert.strictEqual(-1, a.compare(b, undefined));
// Equivalent to a.compare(b). // Equivalent to a.compare(b).
assert.strictEqual(-1, a.compare(b, 0, undefined, 0)); assert.strictEqual(-1, a.compare(b, 0, undefined, 0));
@ -63,5 +64,6 @@ assert.throws(() => a.compare(b, 0, 1, 0, 100), oor);
assert.throws(() => a.compare(b, -1), oor); assert.throws(() => a.compare(b, -1), oor);
assert.throws(() => a.compare(b, 0, '0xff'), oor); assert.throws(() => a.compare(b, 0, '0xff'), oor);
assert.throws(() => a.compare(b, 0, Infinity), oor); assert.throws(() => a.compare(b, 0, Infinity), oor);
assert.throws(() => a.compare(b, 0, 1, -1), oor);
assert.throws(() => a.compare(b, -Infinity, Infinity), oor); assert.throws(() => a.compare(b, -Infinity, Infinity), oor);
assert.throws(() => a.compare(), /Argument must be a Buffer/); assert.throws(() => a.compare(), /Argument must be a Buffer/);

11
test/parallel/test-buffer-write-noassert.js
View File

@ -20,6 +20,17 @@ function write(funx, args, result, res) {
); );
} }
{
const error = /Int/.test(funx) ?
/^TypeError: "buffer" argument must be a Buffer or Uint8Array$/ :
/^TypeError: argument should be a Buffer$/;
assert.throws(
() => Buffer.alloc(9)[funx].apply(new Uint32Array(1), args),
error
);
}
{ {
const buf2 = Buffer.alloc(9); const buf2 = Buffer.alloc(9);
assert.strictEqual(buf2[funx](...args, true), result); assert.strictEqual(buf2[funx](...args, true), result);