1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: favor strict equality in pummel net tests

Browse Source 
Favor strict equality checks over loose equality checks in
pummel/test-net-* tests.

PR-URL: https://github.com/nodejs/node/pull/8135
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2016-08-16 21:11:22 -07:00
parent a0971b7da0
commit 8ff3d61d8b
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/pummel/test-net-connect-econnrefused.js
View File

@ -19,7 +19,7 @@ function pummel() {
net.createConnection(common.PORT).on('error', function(err) { net.createConnection(common.PORT).on('error', function(err) {
assert.equal(err.code, 'ECONNREFUSED'); assert.equal(err.code, 'ECONNREFUSED');
if (--pending > 0) return; if (--pending > 0) return;
if (rounds == ROUNDS) return check(); if (rounds === ROUNDS) return check();
rounds++; rounds++;
pummel(); pummel();
}); });

2
test/pummel/test-net-connect-memleak.js
View File

@ -17,7 +17,7 @@ var before = 0;
before = process.memoryUsage().rss; before = process.memoryUsage().rss;
net.createConnection(common.PORT, '127.0.0.1', function() { net.createConnection(common.PORT, '127.0.0.1', function() {
assert(junk.length != 0); // keep reference alive assert.notStrictEqual(junk.length, 0); // keep reference alive
setTimeout(done, 10); setTimeout(done, 10);
global.gc(); global.gc();
}); });

2
test/pummel/test-net-many-clients.js
View File

@ -69,7 +69,7 @@ server.listen(common.PORT, function() {
var finished_clients = 0; var finished_clients = 0;
for (var i = 0; i < concurrency; i++) { for (var i = 0; i < concurrency; i++) {
runClient(function() { runClient(function() {
if (++finished_clients == concurrency) server.close(); if (++finished_clients === concurrency) server.close();
}); });
} }
}); });

2
test/pummel/test-net-timeout.js
View File

@ -52,7 +52,7 @@ echo_server.listen(common.PORT, function() {
client.write('hello\r\n'); client.write('hello\r\n');
}, 500); }, 500);
if (exchanges == 5) { if (exchanges === 5) {
console.log('wait for timeout - should come in ' + timeout + ' ms'); console.log('wait for timeout - should come in ' + timeout + ' ms');
starttime = new Date(); starttime = new Date();
console.dir(starttime); console.dir(starttime);

2
test/pummel/test-net-timeout2.js
View File

@ -14,7 +14,7 @@ var server = net.createServer(function(socket) {
var interval = setInterval(function() { var interval = setInterval(function() {
counter++; counter++;
if (counter == seconds) { if (counter === seconds) {
clearInterval(interval); clearInterval(interval);
server.close(); server.close();
socket.destroy(); socket.destroy();