1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix strictEqual argument order

Browse Source 
Fix the order of assert.strictEqual() arguments.
It should have first argument as the calculated/tested value.

PR-URL: https://github.com/nodejs/node/pull/24153
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Martin Kask 2018-11-06 16:59:38 +02:00 committed by Rich Trott
parent 1532232dd9
commit 8efad193a1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/parallel/test-buffer-slice.js
View File

@ -24,8 +24,8 @@
require('../common'); require('../common');
const assert = require('assert'); const assert = require('assert');
assert.strictEqual(0, Buffer.from('hello', 'utf8').slice(0, 0).length); assert.strictEqual(Buffer.from('hello', 'utf8').slice(0, 0).length, 0);
assert.strictEqual(0, Buffer('hello', 'utf8').slice(0, 0).length); assert.strictEqual(Buffer('hello', 'utf8').slice(0, 0).length, 0);
const buf = Buffer.from('0123456789', 'utf8'); const buf = Buffer.from('0123456789', 'utf8');
const expectedSameBufs = [ const expectedSameBufs = [
@ -72,7 +72,7 @@ for (let i = 0, s = buf.toString(); i < buf.length; ++i) {
} }
expectedSameBufs.forEach(([buf1, buf2]) => { expectedSameBufs.forEach(([buf1, buf2]) => {
assert.strictEqual(0, Buffer.compare(buf1, buf2)); assert.strictEqual(Buffer.compare(buf1, buf2), 0);
}); });
const utf16Buf = Buffer.from('0123456789', 'utf16le'); const utf16Buf = Buffer.from('0123456789', 'utf16le');
@ -83,12 +83,12 @@ assert.strictEqual(Buffer.alloc(0).slice(0, 1).length, 0);
{ {
// Single argument slice // Single argument slice
assert.strictEqual('bcde', assert.strictEqual(Buffer.from('abcde', 'utf8').slice(1).toString('utf8'),
Buffer.from('abcde', 'utf8').slice(1).toString('utf8')); 'bcde');
} }
// slice(0,0).length === 0 // slice(0,0).length === 0
assert.strictEqual(0, Buffer.from('hello', 'utf8').slice(0, 0).length); assert.strictEqual(Buffer.from('hello', 'utf8').slice(0, 0).length, 0);
{ {
// Regression tests for https://github.com/nodejs/node/issues/9096 // Regression tests for https://github.com/nodejs/node/issues/9096