1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: fix readability/inheritance cpplint warnings

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Ben Noordhuis 2016-06-28 21:21:21 +02:00
parent df3a192496
commit 8e395222de
6 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/async-wrap.cc
View File

@ -38,11 +38,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
public: public:
explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap); explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);
virtual void Dispose() override; void Dispose() override;
virtual bool IsEquivalent(RetainedObjectInfo* other) override; bool IsEquivalent(RetainedObjectInfo* other) override;
virtual intptr_t GetHash() override; intptr_t GetHash() override;
virtual const char* GetLabel() override; const char* GetLabel() override;
virtual intptr_t GetSizeInBytes() override; intptr_t GetSizeInBytes() override;
private: private:
const char* label_; const char* label_;

2
src/cares_wrap.cc
View File

@ -257,7 +257,7 @@ class QueryWrap : public AsyncWrap {
req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0)); req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
} }
virtual ~QueryWrap() override { ~QueryWrap() override {
CHECK_EQ(false, persistent().IsEmpty()); CHECK_EQ(false, persistent().IsEmpty());
ClearWrap(object()); ClearWrap(object());
persistent().Reset(); persistent().Reset();

2
src/fs_event_wrap.cc
View File

@ -35,7 +35,7 @@ class FSEventWrap: public HandleWrap {
private: private:
FSEventWrap(Environment* env, Local<Object> object); FSEventWrap(Environment* env, Local<Object> object);
virtual ~FSEventWrap() override; ~FSEventWrap() override;
static void OnEvent(uv_fs_event_t* handle, const char* filename, int events, static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
int status); int status);

2
src/handle_wrap.h
View File

@ -55,7 +55,7 @@ class HandleWrap : public AsyncWrap {
uv_handle_t* handle, uv_handle_t* handle,
AsyncWrap::ProviderType provider, AsyncWrap::ProviderType provider,
AsyncWrap* parent = nullptr); AsyncWrap* parent = nullptr);
virtual ~HandleWrap() override; ~HandleWrap() override;
private: private:
friend class Environment; friend class Environment;

9
src/inspector_agent.cc
View File

@ -240,18 +240,15 @@ class ChannelImpl final : public blink::protocol::FrontendChannel {
explicit ChannelImpl(AgentImpl* agent): agent_(agent) {} explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
virtual ~ChannelImpl() {} virtual ~ChannelImpl() {}
private: private:
virtual void sendProtocolResponse(int callId, void sendProtocolResponse(int callId, const String16& message) override {
const String16& message)
override {
sendMessageToFrontend(message); sendMessageToFrontend(message);
} }
virtual void sendProtocolNotification( void sendProtocolNotification(const String16& message) override {
const String16& message) override {
sendMessageToFrontend(message); sendMessageToFrontend(message);
} }
virtual void flushProtocolNotifications() override { } void flushProtocolNotifications() override { }
void sendMessageToFrontend(const String16& message) { void sendMessageToFrontend(const String16& message) {
agent_->Write(message.utf8()); agent_->Write(message.utf8());

2
src/node_stat_watcher.h
View File

@ -13,7 +13,7 @@ namespace node {
class StatWatcher : public AsyncWrap { class StatWatcher : public AsyncWrap {
public: public:
virtual ~StatWatcher() override; ~StatWatcher() override;
static void Initialize(Environment* env, v8::Local<v8::Object> target); static void Initialize(Environment* env, v8::Local<v8::Object> target);