From 8e189794dfd4a83378af50358c68f97eb65cf1b2 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 26 Aug 2018 19:39:29 -0700 Subject: [PATCH] test: remove skip of OS X bug Three tests are skipped because of Applie bug 17894467. That bug exists in OS X 10.10, but we no longer support 10.10 (and neither does Apple). Remove the test-skipping. PR-URL: https://github.com/nodejs/node/pull/22546 Reviewed-By: Luigi Pinca Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Daniel Bevenius Reviewed-By: Trivikram Kamat Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell --- test/parallel/test-dgram-send-empty-array.js | 3 --- test/parallel/test-dgram-send-empty-buffer.js | 2 -- test/parallel/test-dgram-send-empty-packet.js | 2 -- 3 files changed, 7 deletions(-) diff --git a/test/parallel/test-dgram-send-empty-array.js b/test/parallel/test-dgram-send-empty-array.js index fe24d8f756b..178b72bb127 100644 --- a/test/parallel/test-dgram-send-empty-array.js +++ b/test/parallel/test-dgram-send-empty-array.js @@ -2,9 +2,6 @@ const common = require('../common'); -if (common.isOSX) - common.skip('because of 17894467 Apple bug'); - const assert = require('assert'); const dgram = require('dgram'); diff --git a/test/parallel/test-dgram-send-empty-buffer.js b/test/parallel/test-dgram-send-empty-buffer.js index 554a3c9185c..76b014b8934 100644 --- a/test/parallel/test-dgram-send-empty-buffer.js +++ b/test/parallel/test-dgram-send-empty-buffer.js @@ -21,8 +21,6 @@ 'use strict'; const common = require('../common'); -if (common.isOSX) - common.skip('because of 17894467 Apple bug'); const assert = require('assert'); const dgram = require('dgram'); diff --git a/test/parallel/test-dgram-send-empty-packet.js b/test/parallel/test-dgram-send-empty-packet.js index b425e9eb158..eb4f79e8aaf 100644 --- a/test/parallel/test-dgram-send-empty-packet.js +++ b/test/parallel/test-dgram-send-empty-packet.js @@ -1,7 +1,5 @@ 'use strict'; const common = require('../common'); -if (common.isOSX) - common.skip('because of 17894467 Apple bug'); const assert = require('assert'); const dgram = require('dgram');