test: remove third argument from assert.strictEqual()
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/22051 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
parent
ce98e2e989
commit
8d15f69abd
@ -59,44 +59,54 @@ The order things are called
|
|||||||
const t = new stream.Transform({
|
const t = new stream.Transform({
|
||||||
objectMode: true,
|
objectMode: true,
|
||||||
transform: common.mustCall(function(chunk, _, next) {
|
transform: common.mustCall(function(chunk, _, next) {
|
||||||
assert.strictEqual(++state, chunk, 'transformCallback part 1');
|
// transformCallback part 1
|
||||||
|
assert.strictEqual(++state, chunk);
|
||||||
this.push(state);
|
this.push(state);
|
||||||
assert.strictEqual(++state, chunk + 2, 'transformCallback part 2');
|
// transformCallback part 2
|
||||||
|
assert.strictEqual(++state, chunk + 2);
|
||||||
process.nextTick(next);
|
process.nextTick(next);
|
||||||
}, 3),
|
}, 3),
|
||||||
final: common.mustCall(function(done) {
|
final: common.mustCall(function(done) {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 10, 'finalCallback part 1');
|
// finalCallback part 1
|
||||||
|
assert.strictEqual(state, 10);
|
||||||
setTimeout(function() {
|
setTimeout(function() {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 11, 'finalCallback part 2');
|
// finalCallback part 2
|
||||||
|
assert.strictEqual(state, 11);
|
||||||
done();
|
done();
|
||||||
}, 100);
|
}, 100);
|
||||||
}, 1),
|
}, 1),
|
||||||
flush: common.mustCall(function(done) {
|
flush: common.mustCall(function(done) {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 12, 'flushCallback part 1');
|
// flushCallback part 1
|
||||||
|
assert.strictEqual(state, 12);
|
||||||
process.nextTick(function() {
|
process.nextTick(function() {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 15, 'flushCallback part 2');
|
// flushCallback part 2
|
||||||
|
assert.strictEqual(state, 15);
|
||||||
done();
|
done();
|
||||||
});
|
});
|
||||||
}, 1)
|
}, 1)
|
||||||
});
|
});
|
||||||
t.on('finish', common.mustCall(function() {
|
t.on('finish', common.mustCall(function() {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 13, 'finishListener');
|
// finishListener
|
||||||
|
assert.strictEqual(state, 13);
|
||||||
}, 1));
|
}, 1));
|
||||||
t.on('end', common.mustCall(function() {
|
t.on('end', common.mustCall(function() {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 16, 'end event');
|
// end event
|
||||||
|
assert.strictEqual(state, 16);
|
||||||
}, 1));
|
}, 1));
|
||||||
t.on('data', common.mustCall(function(d) {
|
t.on('data', common.mustCall(function(d) {
|
||||||
assert.strictEqual(++state, d + 1, 'dataListener');
|
// dataListener
|
||||||
|
assert.strictEqual(++state, d + 1);
|
||||||
}, 3));
|
}, 3));
|
||||||
t.write(1);
|
t.write(1);
|
||||||
t.write(4);
|
t.write(4);
|
||||||
t.end(7, common.mustCall(function() {
|
t.end(7, common.mustCall(function() {
|
||||||
state++;
|
state++;
|
||||||
assert.strictEqual(state, 14, 'endMethodCallback');
|
// endMethodCallback
|
||||||
|
assert.strictEqual(state, 14);
|
||||||
}, 1));
|
}, 1));
|
||||||
|
Loading…
x
Reference in New Issue
Block a user