1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-stream2-objects.js

Browse Source 
This commit improves the test cases in
test-stream2-objects.js by using assert.strictEqual
instead of assert.equal.

This is a part of Code And Learn at NodeFest 2016

Fixes: https://github.com/nodejs/code-and-learn/issues/58
PR-URL: https://github.com/nodejs/node/pull/9565
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Yoshiya Hinosawa 2016-11-12 16:26:52 +09:00 committed by Shigeki Ohtsu
parent 7030f094cd
commit 8ca322d613
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-stream2-objects.js
View File

@ -33,7 +33,7 @@ function run() {
// ensure all tests have run // ensure all tests have run
process.on('exit', function() { process.on('exit', function() {
assert.equal(count, 0); assert.strictEqual(count, 0);
}); });
process.nextTick(run); process.nextTick(run);
@ -210,16 +210,16 @@ test('high watermark _read', function(t) {
var v = r.read(); var v = r.read();
assert.equal(calls, 0); assert.strictEqual(calls, 0);
assert.equal(v, '1'); assert.strictEqual(v, '1');
var v2 = r.read(); var v2 = r.read();
assert.equal(v2, '2'); assert.strictEqual(v2, '2');
var v3 = r.read(); var v3 = r.read();
assert.equal(v3, '3'); assert.strictEqual(v3, '3');
assert.equal(calls, 1); assert.strictEqual(calls, 1);
t.end(); t.end();
}); });
@ -232,7 +232,7 @@ test('high watermark push', function(t) {
r._read = function(n) {}; r._read = function(n) {};
for (var i = 0; i < 6; i++) { for (var i = 0; i < 6; i++) {
var bool = r.push(i); var bool = r.push(i);
assert.equal(bool, i === 5 ? false : true); assert.strictEqual(bool, i !== 5);
} }
t.end(); t.end();
@ -309,7 +309,7 @@ test('buffers finish until cb is called', function(t) {
var called = false; var called = false;
w._write = function(chunk, encoding, cb) { w._write = function(chunk, encoding, cb) {
assert.equal(chunk, 'foo'); assert.strictEqual(chunk, 'foo');
process.nextTick(function() { process.nextTick(function() {
called = true; called = true;
@ -318,7 +318,7 @@ test('buffers finish until cb is called', function(t) {
}; };
w.on('finish', function() { w.on('finish', function() {
assert.equal(called, true); assert.strictEqual(called, true);
t.end(); t.end();
}); });