1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: split out http2 from test-stream-pipeline

Browse Source 
Splitting out the http2 portion of the test has a few benfits:

* We don't skip the rest of the tests if `node` is compiled without
  crypto.
* We can find out if the http2 portion of the test is responsible for
  the timeouts reported in issue 24456.

Refs: https://github.com/nodejs/node/issues/24456

PR-URL: https://github.com/nodejs/node/pull/24631
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Rich Trott 2018-11-24 11:27:15 -08:00
parent 824f16c861
commit 8c0aa84f85
3 changed files with 38 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/parallel.status
View File

@ -12,6 +12,8 @@ test-net-connect-options-port: PASS,FLAKY
test-http2-pipe: PASS,FLAKY test-http2-pipe: PASS,FLAKY
test-worker-syntax-error: PASS,FLAKY test-worker-syntax-error: PASS,FLAKY
test-worker-syntax-error-file: PASS,FLAKY test-worker-syntax-error-file: PASS,FLAKY
# https://github.com/nodejs/node/issues/24456
test-stream-pipeline-http2: PASS,FLAKY
[$system==linux] [$system==linux]

36
test/parallel/test-stream-pipeline-http2.js Normal file
View File

@ -0,0 +1,36 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const { Readable, pipeline } = require('stream');
const http2 = require('http2');
{
const server = http2.createServer((req, res) => {
pipeline(req, res, common.mustCall());
});
server.listen(0, () => {
const url = `http://localhost:${server.address().port}`;
const client = http2.connect(url);
const req = client.request({ ':method': 'POST' });
const rs = new Readable({
read() {
rs.push('hello');
}
});
pipeline(rs, req, common.mustCall((err) => {
server.close();
client.close();
}));
let cnt = 10;
req.on('data', (data) => {
cnt--;
if (cnt === 0) rs.destroy();
});
});
}

32
test/parallel/test-stream-pipeline.js
View File

@ -1,12 +1,9 @@
'use strict'; 'use strict';
const common = require('../common'); const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const { Stream, Writable, Readable, Transform, pipeline } = require('stream'); const { Stream, Writable, Readable, Transform, pipeline } = require('stream');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
const http2 = require('http2');
const { promisify } = require('util'); const { promisify } = require('util');
{ {
@ -275,35 +272,6 @@ const { promisify } = require('util');
}); });
} }
{
const server = http2.createServer((req, res) => {
pipeline(req, res, common.mustCall());
});
server.listen(0, () => {
const url = `http://localhost:${server.address().port}`;
const client = http2.connect(url);
const req = client.request({ ':method': 'POST' });
const rs = new Readable({
read() {
rs.push('hello');
}
});
pipeline(rs, req, common.mustCall((err) => {
server.close();
client.close();
}));
let cnt = 10;
req.on('data', (data) => {
cnt--;
if (cnt === 0) rs.destroy();
});
});
}
{ {
const makeTransform = () => { const makeTransform = () => {
const tr = new Transform({ const tr = new Transform({